Review workflow UI improvements. #319
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…gin." This reverts commit 99b9a47.
|
r=? @leplatrem |
|
I think you forgot to add the tests file. Good news is that CI is not gonna break :) |
|
Ah sorry for that, pushed in b4aadb3 |
leplatrem
approved these changes
Nov 17, 2016
| setData() {}, | ||
| }; | ||
| bucket = {collection() {return collection;}}; | ||
| setClient({bucket() {return bucket;}}); |
There was a problem hiding this comment.
nit: maybe put all that in a fakeClient variable shared with all tests?
| const {id: userId} = user; | ||
| console.log(bucketState); | ||
| const {groups} = bucketState; | ||
| const editorGroup = groups.find(g => g.id === groupName); |
There was a problem hiding this comment.
nit: editorGroup → group
| return false; | ||
| } | ||
| const {signer={}} = capabilities; | ||
| const {[groupkey]: defaultGroupName} = signer; |
There was a problem hiding this comment.
We could even do this in one line without intermediary capabilities and signer variables :) #PerlFTW
There was a problem hiding this comment.
You mean
const {serverInfo: {capabilities: {signer: {[groupKey]: defaultGroupName}={}}}} = sessionState;LOLNOPE 😬
| const {[groupkey]: defaultGroupName} = signer; | ||
| const {[groupkey]: groupName=defaultGroupName} = source; | ||
| const {id: userId} = user; | ||
| console.log(bucketState); |
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #317 and other issues. WiP.