Add command to reindex existing data (fixes #20) #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Natim
reviewed
Sep 8, 2017
| if cli_args is None: | ||
| cli_args = sys.argv[1:] | ||
|
|
||
| parser = argparse.ArgumentParser() |
There was a problem hiding this comment.
Do you think we could work on adding an entry-point so that plugins can add sub-commands to the kinto command?
There was a problem hiding this comment.
I have created Kinto/kinto#1330 about that.
Natim
reviewed
Sep 8, 2017
| print("No `index:schema` attribute found in collection metadata.") | ||
| return 42 | ||
|
|
||
| # XXX: Are you sure? |
There was a problem hiding this comment.
Instead we could add a --dry-run or a `--recreate`` attribute
Natim
force-pushed
the
20-index-existing-records
branch
from
6ac688f
to
f6e2b41
Compare
added 2 commits
September 8, 2017 12:20
Natim
force-pushed
the
20-index-existing-records
branch
from
4bafe14
to
c583578
Compare
Natim
changed the title
leplatrem
commented
Sep 12, 2017
|
|
||
| kinto.permission_backend = kinto.core.permission.postgresql | ||
| kinto.permission_url = postgres://postgres:postgres@localhost:5432/postgres | ||
|
|
There was a problem hiding this comment.
@Natim is this intentional?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #20
@Natim I let you take over. The only remaining challenge is to paginate the call to
get_all(). The rest seems to work according to a few quick manual tests