-
Notifications
You must be signed in to change notification settings - Fork 7
Workflow with a preview collection (fixes #126) #127
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM besides a few nits
@@ -185,6 +185,20 @@ makes sure that: | |||
|
|||
See `Kinto groups API <http://kinto.readthedocs.io/en/stable/api/1.x/groups.html>`_ for more details about how to define groups. | |||
|
|||
If the review process is enabled, it is possible to configure a *preview* | |||
collection, that will be updated and signed when the status is set to ``to-review``. | |||
This *preview* collection can be used by client to test and validate the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
s/client/clients
.. code-block:: ini | ||
|
||
kinto.signer.resources = | ||
/buckets/staging/collections/articles;/buckets/preview/collections/articles;/buckets/blog/collections/articles |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just an proposal, feel free to ignore, but could we use "=>" instead of ";" to show the worklfow
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good idea! I added it to #88
@@ -345,6 +359,12 @@ To generate a new keypair, you can use the following command:: | |||
Running the tests | |||
================= | |||
|
|||
In order to contribute and run the full functional test suite locally you need |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why ? can't we use the latest binary of autograph ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we use go get
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In that case we should pin the autograph version we use to the latest release I think.
@@ -310,6 +327,8 @@ def update_source_status(self, status, request): | |||
attrs = {'status': status.value} | |||
if status == STATUS.WORK_IN_PROGRESS: | |||
attrs["last_author"] = request.prefixed_userid | |||
if status == STATUS.TO_REVIEW: | |||
attrs["last_editor"] = request.prefixed_userid |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do we want last_author, last_editor, last_reviewer to be constants ?
r+ |
Fixes #126
(source, None, destination)
if two provided)to-sign
toto-review
@tarekziade r?