This repository has been archived by the owner on Jan 25, 2022. It is now read-only.
Workflow with a preview collection (fixes #126) #127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tarekziade
approved these changes
Sep 29, 2016
| @@ -185,6 +185,20 @@ makes sure that: | |||
|
|
|||
| See `Kinto groups API <http://kinto.readthedocs.io/en/stable/api/1.x/groups.html>`_ for more details about how to define groups. | |||
|
|
|||
| If the review process is enabled, it is possible to configure a *preview* | |||
| collection, that will be updated and signed when the status is set to ``to-review``. | |||
| This *preview* collection can be used by client to test and validate the changes | |||
| .. code-block:: ini | ||
|
|
||
| kinto.signer.resources = | ||
| /buckets/staging/collections/articles;/buckets/preview/collections/articles;/buckets/blog/collections/articles |
There was a problem hiding this comment.
just an proposal, feel free to ignore, but could we use "=>" instead of ";" to show the worklfow
There was a problem hiding this comment.
Good idea! I added it to #88
| @@ -345,6 +359,12 @@ To generate a new keypair, you can use the following command:: | |||
| Running the tests | |||
| ================= | |||
|
|
|||
| In order to contribute and run the full functional test suite locally you need | |||
There was a problem hiding this comment.
why ? can't we use the latest binary of autograph ?
There was a problem hiding this comment.
In that case we should pin the autograph version we use to the latest release I think.
| @@ -310,6 +327,8 @@ def update_source_status(self, status, request): | |||
| attrs = {'status': status.value} | |||
| if status == STATUS.WORK_IN_PROGRESS: | |||
| attrs["last_author"] = request.prefixed_userid | |||
| if status == STATUS.TO_REVIEW: | |||
| attrs["last_editor"] = request.prefixed_userid | |||
There was a problem hiding this comment.
do we want last_author, last_editor, last_reviewer to be constants ?
leplatrem
changed the title
|
r+ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #126
(source, None, destination)if two provided)to-signtoto-review@tarekziade r?