Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
Fix URL formation on Windows and URL symbols in custom ID breaking cache storage #134
This PR should fix MLIBZ-1919 and MLIBZ-1677.
Parse path segments for cache requests manually and remove library from dependencies. Add library for joining URLs and ensure paths don't start with multiple slashes, because that broke the assertions in the tests due to discrepancies between mocked URLs and requested URLs.
Added new test for "." in _id. Old tests pass.
@thomasconner Other special characters seem to fail. If you want to release today, you might take a look. Otherwise I will work it out on Monday.
@@ Coverage Diff @@ ## master #134 +/- ## ========================================= + Coverage 90.45% 90.5% +0.04% ========================================= Files 77 77 Lines 6421 6432 +11 Branches 1035 1034 -1 ========================================= + Hits 5808 5821 +13 + Misses 613 611 -2