Fix URL formation on Windows and URL symbols in custom ID breaking cache storage #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…of using the library "url-pattern". Remove it from package.json, since it's not used anywhere else. Library did not match any parts of the URL when a custom ID was used, which contained any of the characters, which had semantic meaning for a URL (., :, etc).
…oin and ensure empty strings or slashes are not the first argument of url-join, because it doesn't handle it well (inserts more than one slash).
Codecov Report
@@ Coverage Diff @@
## master #134 +/- ##
=========================================
+ Coverage 90.45% 90.5% +0.04%
=========================================
Files 77 77
Lines 6421 6432 +11
Branches 1035 1034 -1
=========================================
+ Hits 5808 5821 +13
+ Misses 613 611 -2
Continue to review full report at Codecov.
|
|
Please see latest commits that allow all special characters. |
thomasconner
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR should fix MLIBZ-1919 and MLIBZ-1677.
Changes
Parse path segments for cache requests manually and remove library from dependencies. Add library for joining URLs and ensure paths don't start with multiple slashes, because that broke the assertions in the tests due to discrepancies between mocked URLs and requested URLs.
Tests
Added new test for "." in _id. Old tests pass.
@thomasconner Other special characters seem to fail. If you want to release today, you might take a look. Otherwise I will work it out on Monday.