Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-1870: Fix Promise Undefined Bug #135

merged 3 commits into from Jul 7, 2017


Copy link

commented Jul 7, 2017


This PR imports the es6-promise library to fix undefined for promises on platforms that do not have native support for promises.


  • Import es6-promise for the CacheStore

@thomasconner thomasconner self-assigned this Jul 7, 2017

@thomasconner thomasconner requested a review from vinaygahlawat Jul 7, 2017

@@ -44,7 +44,7 @@
"promise-queue": "2.2.3",
"qs": "6.4.0",
"request": "2.81.0",
"rxjs": "5.2.0",
"rxjs": "5.4.2",

This comment has been minimized.

Copy link

tejasranade Jul 7, 2017


@thomasconner if this is an unrelated change, can you take it out?

This comment has been minimized.

Copy link

thomasconner Jul 7, 2017

Author Contributor

It has been reverted.

Revert "Update rxjs dependency"
This reverts commit f8b8976.

This comment has been minimized.

Copy link

commented Jul 7, 2017

Codecov Report

Merging #135 into master will decrease coverage by 0.11%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #135      +/-   ##
- Coverage   90.45%   90.33%   -0.12%     
  Files          77       77              
  Lines        6421     6426       +5     
  Branches     1035     1035              
- Hits         5808     5805       -3     
- Misses        613      621       +8
Impacted Files Coverage Δ
src/datastore/src/cachestore.js 93.58% <100%> (-1.28%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1107bc1...c3c392f. Read the comment docs.

@thomasconner thomasconner merged commit ba922bd into master Jul 7, 2017

2 checks passed

codeclimate no new or fixed issues
continuous-integration/travis-ci/push The Travis CI build passed

@thomasconner thomasconner deleted the MLIBZ-1870_Promise_undefined branch Jul 7, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
3 participants
You can’t perform that action at this time.