MLIBZ-1870: Fix Promise Undefined Bug #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tejasranade
reviewed
Jul 7, 2017
package.json
Outdated
| @@ -44,7 +44,7 @@ | |||
| "promise-queue": "2.2.3", | |||
| "qs": "6.4.0", | |||
| "request": "2.81.0", | |||
| "rxjs": "5.2.0", | |||
| "rxjs": "5.4.2", | |||
There was a problem hiding this comment.
@thomasconner if this is an unrelated change, can you take it out?
There was a problem hiding this comment.
It has been reverted.
This reverts commit f8b8976.
Codecov Report
@@ Coverage Diff @@
## master #135 +/- ##
==========================================
- Coverage 90.45% 90.33% -0.12%
==========================================
Files 77 77
Lines 6421 6426 +5
Branches 1035 1035
==========================================
- Hits 5808 5805 -3
- Misses 613 621 +8
Continue to review full report at Codecov.
|
tejasranade
approved these changes
Jul 7, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR imports the
es6-promiselibrary to fixundefinedfor promises on platforms that do not have native support for promises.Changes
es6-promisefor theCacheStore