Join GitHub today
GitHub is home to over 40 million developers working together to host and review code, manage projects, and build software together.Sign up
MLIBZ-2350 Revert removal of caching db connections in WebSQL. #241
During the mono repo move (I believe. this is the commit here), the caching of database connections was removed. This caused problems when making many operations in websql, since each one would "open" the database. We encountered this in the unit tests suite.
Add back the caching of "open" databases.
@thomasconner , why was this removed in the first place? Perhaps we shouldn't bring it back? Also, there didn't seem to be a mechanism for closing or removing these from cache. Is that the way it should be?
@tsvetomir-nedyalkov asked me to take this on, since it's causing problems with integration tests and would force him to disable running the tests on phonegap in general. I had tracked it down to this perticular commit, so I figured it won't be too difficult to revert the change. And if this is all that needs doing, we better do it sooner, rather than later, and have a more robust integration test suite.