Add default entitlements plist file to nativescript sdk #281
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <dict> | ||
| <key>keychain-access-groups</key> | ||
| <array> | ||
| <string>$(AppIdentifierPrefix)$(PRODUCT_BUNDLE_IDENTIFIER)</string> |
There was a problem hiding this comment.
How did you determine this should be the value here?
There was a problem hiding this comment.
Good question. I believe I found this as the recommended default. It's basically a way to create a group identifier without having to hardcode any part of it. Here's some info on it - https://stackoverflow.com/a/39437477
And this is a tutorial on what the value means - https://evgenii.com/blog/sharing-keychain-in-ios/
I'll try to find the official docs about this, but we've been using this same value in all our sample apps and templates. @
There was a problem hiding this comment.
Ok thanks for the explanation.
thomasconner
approved these changes
Mar 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Refer to Kinvey/nativescript-sdk#31 for details on the issue and and proposed fix.
Changes
This PR adds a default
app.entitlementsfile to the nativescript-sdk.Tests
Tested manually with a MIC sample (https://github.com/tejasranade/EnterpriseSSO)