Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MLIBZ-2889: Add version to MIC urls #415

Merged
merged 2 commits into from
Jun 14, 2019
Merged

MLIBZ-2889: Add version to MIC urls #415

merged 2 commits into from
Jun 14, 2019

Conversation

thomasconner
Copy link
Contributor

No description provided.

@thomasconner thomasconner self-assigned this Jun 11, 2019
vinaygahlawat
vinaygahlawat suggested changes Jun 11, 2019
View reviewed changes
Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but please add unit tests to cover and validate this.

@thomasconner thomasconner merged commit b4974e3 into master Jun 14, 2019
@thomasconner thomasconner deleted the MLIBZ-2889 branch June 14, 2019 01:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinaygahlawat vinaygahlawat vinaygahlawat approved these changes

Assignees

@thomasconner thomasconner

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thomasconner @vinaygahlawat