Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2409: removeAll() request #274

Merged
merged 1 commit into from
Mar 19, 2018

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented Mar 16, 2018

Description

removeAll() must generate a request like /appdata/kid/collection?query={} instead of only /appdata/kid/collection

Changes

  • Be able to force a query param when is needed

Tests

  • Unit Test added to cover the use case

@heyzooi heyzooi self-assigned this Mar 16, 2018
@codecov-io
Copy link

codecov-io commented Mar 19, 2018

Codecov Report

Merging #274 into develop will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #274      +/-   ##
===========================================
+ Coverage    88.28%   88.28%   +<.01%     
===========================================
  Files           68       68              
  Lines         8524     8526       +2     
===========================================
+ Hits          7525     7527       +2     
  Misses         999      999
Flag Coverage Δ
#Mac 87.73% <100%> (+0.09%) ⬆️
#iOS 86.69% <100%> (-0.12%) ⬇️
Impacted Files Coverage Δ
Kinvey/Kinvey/Query.swift 95.62% <100%> (ø) ⬆️
Kinvey/Kinvey/HttpRequestFactory.swift 99.17% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2013db0...e25dbdf. Read the comment docs.

@heyzooi heyzooi merged commit b7aed40 into develop Mar 19, 2018
@heyzooi heyzooi deleted the feature/MLIBZ-2409-remove_all_request branch March 19, 2018 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants