Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MLIBZ-2482: making the validation strategy work as intended #285

Merged
merged 1 commit into from
May 7, 2018

Conversation

heyzooi
Copy link
Contributor

@heyzooi heyzooi commented May 2, 2018

Description

ValidationStrategy were not working as intended since it was not skipping our usual validation if a validation strategy was used

Changes

  • Changing the entity mapping to use a validation strategy (if provided)

Tests

  • Making sure the unit tests are iterating in the results

@heyzooi heyzooi self-assigned this May 2, 2018
@codecov-io
Copy link

codecov-io commented May 2, 2018

Codecov Report

Merging #285 into develop will increase coverage by 0.06%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           develop    #285      +/-   ##
==========================================
+ Coverage    88.84%   88.9%   +0.06%     
==========================================
  Files           69      69              
  Lines         8722    8728       +6     
==========================================
+ Hits          7749    7760      +11     
+ Misses         973     968       -5
Flag Coverage Δ
#Mac 88.29% <20%> (+0.05%) ⬆️
#iOS 87.72% <20%> (-0.02%) ⬇️
Impacted Files Coverage Δ
Kinvey/Kinvey/ValidationStrategy.swift 91.66% <ø> (+8.33%) ⬆️
Kinvey/Kinvey/Entity.swift 84.74% <0%> (-4.54%) ⬇️
Kinvey/Kinvey/FindOperation.swift 96.42% <100%> (+0.35%) ⬆️
Kinvey/Kinvey/Kinvey.swift 95.97% <0%> (+0.67%) ⬆️
Kinvey/Kinvey/PubNubRealtimeRouter.swift 78.94% <0%> (+1.31%) ⬆️
Kinvey/Kinvey/Migration.swift 39.02% <0%> (+14.63%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7cdafc8...655585c. Read the comment docs.

Copy link
Contributor

@vinaygahlawat vinaygahlawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@heyzooi heyzooi merged commit 9f26819 into develop May 7, 2018
@heyzooi heyzooi deleted the feature/MLIBZ-2482-validation_strategy_fix branch May 7, 2018 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants