MLIBZ-2719: Prevent multiple calls to refresh token #330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kinvey/Kinvey/HttpRequest.swift
Outdated
| if let user = self.credential as? User { | ||
| user.logout() | ||
| DispatchQueue.global(qos: .default).async { | ||
| guard !client.refreshingToken else { |
There was a problem hiding this comment.
Is the client.refreshingToken made thread-safe because it is being accessed and set from within the DispatchQueue?
There was a problem hiding this comment.
right, so this is a serial queue and I'm calling wait() on the DispatchGroup so the combination of both makes the entire refresh token process thread-safe
…ppen right after the first request
Codecov Report
@@ Coverage Diff @@
## develop #330 +/- ##
===========================================
+ Coverage 86.3% 86.35% +0.05%
===========================================
Files 70 70
Lines 8431 8470 +39
===========================================
+ Hits 7276 7314 +38
- Misses 1155 1156 +1
Continue to review full report at Codecov.
|
vinaygahlawat
approved these changes
Oct 26, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prevent multiple calls to refresh token which was causing a race condition
Changes
User,ClientandHttpRequestoperations are queued when a401response is returnedTests