Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency tslog to v4 #347

Open
wants to merge 2 commits into
base: dev-main
Choose a base branch
from
Open

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Nov 13, 2022

Mend Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
tslog (source) ^3.3.0 -> ^4.0.0 age adoption passing confidence

Configuration

πŸ“… Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

β™» Rebasing: Renovate will not automatically rebase this PR, because other commits have been found.

πŸ”• Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate. View repository job log here.

@renovate renovate bot added the dependencies Updates or changes a dependency file label Nov 13, 2022
@Luna-Klatzer Luna-Klatzer changed the base branch from main to dev November 16, 2022 14:34
…as kipper is still strictly 'commonjs' for now)
@github-actions
Copy link
Contributor

size-limit report πŸ“¦

Path Size Loading time (3g) Running time (snapdragon) Total time
./kipper/web/kipper-standalone.min.js 120.77 KB (0%) 2.5 s (0%) 1.1 s (+30.6% πŸ”Ί) 3.6 s
./kipper/web/kipper-standalone.js 120.81 KB (0%) 2.5 s (0%) 941 ms (-14.36% πŸ”½) 3.4 s

@Luna-Klatzer
Copy link
Member

Luna-Klatzer commented Nov 17, 2022

Due to the usage of pure ESM by tslog this PR can't be merged, since all Kipper packages use commonjs with TypeScript imports/exports, meaning that importing would only be possible using an async call, which would heavily complicate the structure of the @kipper/cli package.

Error that is currently thrown due to this issue:

(node:2025) [ERR_REQUIRE_ESM] Error Plugin: @kipper/cli [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/runner/work/Kipper/Kipper/kipper/cli/node_modules/.pnpm/tslog@4.0.4/node_modules/tslog/dist/nodejs/index.js
require() of ES modules is not supported.
require() of /home/runner/work/Kipper/Kipper/kipper/cli/node_modules/.pnpm/tslog@4.0.4/node_modules/tslog/dist/nodejs/index.js from /home/runner/work/Kipper/Kipper/kipper/cli/src/logger.ts is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /home/runner/work/Kipper/Kipper/kipper/cli/node_modules/.pnpm/tslog@4.0.4/node_modules/tslog/package.json.

Traceback copied from run 5821414934 of nodejs-cli-run.yml.

Note:
Currently, there are no concrete plans to make Kipper both support commonjs and ESM or migrate to strict ESM, but in the future, it is likely that either one will be implemented, as ESM replaces more and more commonjs projects.

@Luna-Klatzer Luna-Klatzer added the question Further information is requested label Nov 17, 2022
@renovate
Copy link
Contributor Author

renovate bot commented Nov 28, 2022

Edited/Blocked Notification

Renovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR.

You can manually request rebase by checking the rebase/retry box above.

⚠ Warning: custom changes will be lost.

@Luna-Klatzer
Copy link
Member

Due to the usage of pure ESM by tslog this PR can't be merged, since all Kipper packages use commonjs with TypeScript imports/exports, meaning that importing would only be possible using an async call, which would heavily complicate the structure of the @kipper/cli package.

Error that is currently thrown due to this issue:

(node:2025) [ERR_REQUIRE_ESM] Error Plugin: @kipper/cli [ERR_REQUIRE_ESM]: Must use import to load ES Module: /home/runner/work/Kipper/Kipper/kipper/cli/node_modules/.pnpm/tslog@4.0.4/node_modules/tslog/dist/nodejs/index.js
require() of ES modules is not supported.
require() of /home/runner/work/Kipper/Kipper/kipper/cli/node_modules/.pnpm/tslog@4.0.4/node_modules/tslog/dist/nodejs/index.js from /home/runner/work/Kipper/Kipper/kipper/cli/src/logger.ts is an ES module file as it is a .js file whose nearest parent package.json contains "type": "module" which defines all .js files in that package scope as ES modules.
Instead rename index.js to end in .cjs, change the requiring code to use import(), or remove "type": "module" from /home/runner/work/Kipper/Kipper/kipper/cli/node_modules/.pnpm/tslog@4.0.4/node_modules/tslog/package.json.

Traceback copied from run 5821414934 of nodejs-cli-run.yml.

Note: Currently, there are no concrete plans to make Kipper both support commonjs and ESM or migrate to strict ESM, but in the future, it is likely that either one will be implemented, as ESM replaces more and more commonjs projects.

As a continuation of this thread, due to the intended support of Deno in the future, Kipper will need to migrate to ESM in some form, as otherwise, importing and support are impossible to achieve natively. Therefore, without ESM support only CLI usage would be available, which limits the use of custom Kipper behaviour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Updates or changes a dependency file question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant