This repository has been archived by the owner on Feb 27, 2021. It is now read-only.
WIP : !!! RBAC . #54 #53
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Don't merge this request since this has some breaking changes |
|
This pull request introduces 4 alerts when merging 37e18fc into 6b1b7a0 - view on LGTM.com new alerts:
|
|
Create the issue number and tad it with the template. |
|
This pull request introduces 7 alerts when merging 25f35c0 into 9a5008d - view on LGTM.com new alerts:
|
prathapvpc
reviewed
Jan 30, 2021
| @Entity('users') | ||
| @Unique(['email']) | ||
| export default class Users { | ||
| export class Users { | ||
| @PrimaryGeneratedColumn() |
prathapvpc
reviewed
Jan 30, 2021
| cascade: ['update'], | ||
| }) | ||
| @JoinColumn({ name: 'id' }) | ||
| roleUsers: RoleUsers[]; |
There was a problem hiding this comment.
This roleUsers property is a single item. So change it ti roleUser
prathapvpc
reviewed
Jan 30, 2021
| import { Roles } from './index'; | ||
|
|
||
| @Entity('role_users') | ||
| export class RoleUsers { |
prathapvpc
reviewed
Jan 30, 2021
|
|
||
| @ManyToOne((type) => Roles, (roles) => roles.roleUsers) | ||
| @JoinColumn({ name: 'roleId' }) | ||
| roles: Roles; |
prathapvpc
reviewed
Jan 30, 2021
| import { Roles } from './index'; | ||
|
|
||
| @Entity('role_actions') | ||
| export class RoleActions { |
prathapvpc
reviewed
Jan 30, 2021
| import { IsString, IsOptional } from 'class-validator'; | ||
|
|
||
| @Entity('roles') | ||
| export class Roles { |
prathapvpc
reviewed
Jan 30, 2021
| async execute(command: AuthCommand) { | ||
| const { user, type } = command; | ||
| const role = await this.roleService.getRoleByName( | ||
| 'SuperAdmin', |
prathapvpc
reviewed
Jan 30, 2021
| generationStrategy: 'increment', | ||
| }, | ||
| { | ||
| name: 'name', |
prathapvpc
reviewed
Jan 30, 2021
| columnNames: ['createdBy'], | ||
| referencedColumnNames: ['id'], | ||
| referencedTableName: 'users', | ||
| onDelete: 'CASCADE', |
There was a problem hiding this comment.
Suggested change
| onDelete: 'CASCADE', | |
| onDelete: 'CASCADE', - better avoid cascade delete, instead use soft delete |
prathapvpc
reviewed
Jan 30, 2021
| }, | ||
| { | ||
| name: 'createdAt', | ||
| type: 'timestamp', |
There was a problem hiding this comment.
Suggested change
| type: 'timestamp', | |
| type: 'timestamp', - better use bigint instead of timestamp. Applicable to all timestamp type |
|
SonarCloud Quality Gate failed.
|
|
This pull request introduces 7 alerts when merging c89fd2f into 6349432 - view on LGTM.com new alerts:
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Role-based access control
CQRS implementation