Fit resolutions to less than 2k x 2k (#1065)

* Fit resolutions to less than 2k x 2k * Integer resolutions * Scale mouse clicks * Move stream maxResolution logic to getDimensions
KittyCAD · Nov 14, 2023 · 2519712 · 2519712 · vercel · Nov 14, 2023
1 parent 381d0b3
commit 2519712
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 24 deletions.
diff --git a/src-tauri/Cargo.lock b/src-tauri/Cargo.lock
diff --git a/src/hooks/useSetupEngineManager.ts b/src/hooks/useSetupEngineManager.ts
@@ -82,9 +82,14 @@ export function useSetupEngineManager(
 }
 
 function getDimensions(streamWidth?: number, streamHeight?: number) {
+  const maxResolution = 2000
   const width = streamWidth ? streamWidth : 0
-  const quadWidth = Math.round(width / 4) * 4
   const height = streamHeight ? streamHeight : 0
-  const quadHeight = Math.round(height / 4) * 4
+  const ratio = Math.min(
+    Math.min(maxResolution / width, maxResolution / height),
+    1.0
+  )
+  const quadWidth = Math.round((width * ratio) / 4) * 4
+  const quadHeight = Math.round((height * ratio) / 4) * 4
   return { width: quadWidth, height: quadHeight }
 }
diff --git a/src/lang/std/engineConnection.ts b/src/lang/std/engineConnection.ts
@@ -640,7 +640,10 @@ export class EngineCommandManager {
 
     // If we already have an engine connection, just need to resize the stream.
     if (this.engineConnection) {
-      this.handleResize({ streamWidth: width, streamHeight: height })
+      this.handleResize({
+        streamWidth: width,
+        streamHeight: height,
+      })
       return
     }