Fit resolutions to less than 2k x 2k

[iterion]

I put in limits on the API side to prevent huge resolutions. But, we still have a few cases where modeling app will request a bigger resolution, like full screen on my biggest monitor.

An unfortunate side-effect of this is that we'll also need to scale the resolution of all mouse events, but I'll do some testing to be sure.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Updated (UTC)
modeling-app	✅ Ready (Inspect)	Visit Preview	Nov 13, 2023 9:12pm

[mlfarrell]

You may have to do more here than just limit the res. I suspect aspect ratios will come into play and also accounting for this weird additional scaling factor in the web -> engine 2D space conversions

[iterion]

Yeah, we definitely will, I tried it out and mouse events definitely get offset. I'll have to think more about how to refactor this first.

[Irev-Dev]

There's a chance that this will work without having to worry about mouse coords, assuming the correct stream width and height are fed into getNormalisedCoordinates (src/lib/utils.ts:80). If not that's probably the place to look to fix anyway.

[iterion]

Oh nice, thanks for the tip, I'll give it a shot.

[iterion]

Ok, that worked for scaling the input, now I just want to remove some of the duplication here. I'm wondering instead if we should do this scaling when we setStreamDimensions instead.

[Irev-Dev]

Ok, that worked for scaling the input, now I just want to remove some of the duplication here. I'm wondering instead if we should do this scaling when we setStreamDimensions instead

That sounds like a good bet to me.

[Irev-Dev]

Very elegant change in the end 🏆