Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SwiftyJSON tests to pass on macOS and Linux #529

Closed
NikitaSullivan opened this issue Jun 10, 2016 · 2 comments
Closed

Fix SwiftyJSON tests to pass on macOS and Linux #529

NikitaSullivan opened this issue Jun 10, 2016 · 2 comments
Milestone
0.24

Comments

@NikitaSullivan
Copy link
Contributor

There's no LinuxMain.swift for testing SwiftyJSON on Linux os, there's also no test suite folder structure for running the tests on Mac OS
@NikitaSullivan NikitaSullivan self-assigned this Jun 14, 2016
@NikitaSullivan NikitaSullivan added this to the 0.20 milestone Jun 15, 2016
@dfirsht dfirsht modified the milestones: 0.22, 0.20 Jun 30, 2016
@NikitaSullivan NikitaSullivan self-assigned this Jul 4, 2016
NikitaSullivan pushed a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 4, 2016
Kitura/Kitura#529 updated and fixed SwiftyJSON tests
3a0d0de
@NikitaSullivan
Copy link
Contributor Author

Pull request submitted with test updates and fixes

@vadimeisenbergibm vadimeisenbergibm mentioned this issue Jul 13, 2016
Closed
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 13, 2016
@irar2
Kitura/Kitura#529 Changes for Linux
a608d9d
@dfirsht dfirsht changed the title There is no LinuxMain.swift for testing SwiftyJSON on Linux os Fix SwiftyJSON tests to pass on macOS and Linux Jul 13, 2016
@dfirsht dfirsht modified the milestones: 0.24, 0.22 Jul 13, 2016
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 13, 2016
@vadimeisenbergibm
Kitura/Kitura#529 introduced JSON.AnyType typealias and reduced ifdefs
4be1c05
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 13, 2016
@vadimeisenbergibm
Kitura/Kitura#529 added usage of JSON.AnyType in Tests
49f82ce
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 13, 2016
@vadimeisenbergibm
Kitura/Kitura#529 fixed more AnyType vs AnyObject usages
c18ed01
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 13, 2016
@vadimeisenbergibm
Kitura/Kitura#529 added autoreleasepool on Linux
61ed176
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 13, 2016
@vadimeisenbergibm
Kitura/Kitura#529 replaced AnyObject with AnyType in SequenceTypeTests
fb96c64
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 13, 2016
@vadimeisenbergibm
Kitura/Kitura#529 replaced AnyObject with JSON.AnyType in StringTests
1ab8dc9
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@vadimeisenbergibm
Kitura/Kitura#529 split a dictionary literal with subdictionary
3602c16 
into explicit subdictionary defintion, while specifying dictionary types
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@vadimeisenbergibm
Kitura/Kitura#529 added conversion from [String: AnyType] to [String:…
1337aea 
… String]
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@vadimeisenbergibm
Kitura/Kitura#529 removed tests for NSArray and NSDictionary on Linux
810819b
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@vadimeisenbergibm
Kitura/Kitura#529 added subarray and specifying literal type
11fa052
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@vadimeisenbergibm
Kitura/Kitura#529 replaced CharacterSet with NSCharacterSet on Linux
da4c349
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@vadimeisenbergibm
Kitura/Kitura#529 removed unnecessary use of NSArray/NSDictionary
de004b4
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@irar2
Kitura/Kitura#529 Fix OSX errors
09a4360
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@irar2
Kitura/Kitura#529 Reverted some changes, removed prints, added castin…
935391d 
…g for Linux
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 14, 2016
@irar2
Kitura/Kitura#529 Enable tests to run on Linux
b43aa8a
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 17, 2016
@irar2
Kitura/Kitura#529 Read data directly from file
cd171da
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 17, 2016
@irar2
Kitura/Kitura#529 Merge branch 'master' into testupdates
52a4fa1
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 18, 2016
@irar2
Kitura/Kitura#529 Change tests for Linux because of difference betwee…
abccbb4 
…n OSX and Linux NSNumber.description
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 19, 2016
@vadimeisenbergibm
Kitura/Kitura#529 changed number property on Linux to use rawBool pro…
10357b3 
…perty for Booleans
vadimeisenbergibm added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 19, 2016
@vadimeisenbergibm
Kitura/Kitura#529 disabled a test due to defect in Foundation on Linux
3aee293 
defect: https://bugs.swift.org/browse/SR-1464?jql=text%20~%20%22NSNumber%22
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 20, 2016
@irar2
Kitura/Kitura#529 Fix Bool in Linux
4d199a4
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 20, 2016
@irar2
Kitura/Kitura#529 Changed/disabled tests because of bugs in NSNumber.…
24c8c26 
…description on Linux
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 20, 2016
@irar2
Kitura/Kitura#529 Disabled tests on Linux because of NSNumber bridgin…
5a69f57 
…g problems and issue 568
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 21, 2016
@irar2
Kitura/Kitura#529 Change nil to NSNull()
2be1ab8
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 21, 2016
@irar2
Kitura/Kitura#529 Fix boolean from NSNumber treatment on Linux
17eaf8f
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 21, 2016
@irar2
Kitura/Kitura#529 Change type of error in throw
0cad783
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 21, 2016
@irar2
Kitura/Kitura#529 Disable tests on Linux because of lack of bridging
cd2f92b
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 24, 2016
@irar2
Kitura/Kitura#529 Fix rawNumber setting for Bool. Disable tests on Li…
8fea787 
…nux because of a bug in CFNumberGetType
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 24, 2016
@irar2
Kitura/Kitura#529 Remove xcodeproj that was added by mistake
0c4a091
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 24, 2016
@irar2
Kitura/Kitura#529 Remove xcworkspace as well
adfb3ed
irar2 added a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 24, 2016
@irar2
Kitura/Kitura#529 Remove debug printing, fix indentation
b43eb8d
shmuelk pushed a commit to IBM-Swift/SwiftyJSON that referenced this issue Jul 25, 2016
@NikitaSullivan @shmuelk
Kitura/Kitura#529 updated and fixed SwiftyJSON tests (#7)
d046668 
* Kitura/Kitura#529 updated and fixed SwiftyJSON tests

* Kitura/Kitura#529 Changes for Linux

* Kitura/Kitura#529 introduced JSON.AnyType typealias and reduced ifdefs

* Kitura/Kitura#529 added usage of JSON.AnyType in Tests

* Kitura/Kitura#529 fixed more AnyType vs AnyObject usages

* Kitura/Kitura#529 added autoreleasepool on Linux

* Kitura/Kitura#529 replaced AnyObject with AnyType in SequenceTypeTests

* Kitura/Kitura#529 replaced AnyObject with JSON.AnyType in StringTests

* Kitura/Kitura#529 split a dictionary literal with subdictionary

into explicit subdictionary defintion, while specifying dictionary types

* Kitura/Kitura#529 added conversion from [String: AnyType] to [String: String]

* Kitura/Kitura#529 removed tests for NSArray and NSDictionary on Linux

* Kitura/Kitura#529 added subarray and specifying literal type

* Kitura/Kitura#529 replaced CharacterSet with NSCharacterSet on Linux

* Kitura/Kitura#529 removed unnecessary use of NSArray/NSDictionary

* Kitura/Kitura#529 Fix OSX errors

* Kitura/Kitura#529 Reverted some changes, removed prints, added casting for Linux

* Kitura/Kitura#529 Enable tests to run on Linux

* Kitura/Kitura#529 Read data directly from file

* Kitura/Kitura#529 Change tests for Linux because of difference between OSX and Linux NSNumber.description

* Kitura/Kitura#529 changed number property on Linux to use rawBool property for Booleans

* added .build to .gitignore

* Kitura/Kitura#529 disabled a test due to defect in Foundation on Linux

defect: https://bugs.swift.org/browse/SR-1464?jql=text%20~%20%22NSNumber%22

* Kitura/Kitura#529 Fix Bool in Linux

* Kitura/Kitura#529 Changed/disabled tests because of bugs in NSNumber.description on Linux

* Kitura/Kitura#529 Disabled tests on Linux because of NSNumber bridging problems and issue 568

* Kitura/Kitura#529 Change nil to NSNull()

* Kitura/Kitura#529 Fix boolean from NSNumber treatment on Linux

* Kitura/Kitura#529 Change type of error in throw

* Kitura/Kitura#529 Disable tests on Linux because of lack of bridging

* Kitura/Kitura#529 Fix rawNumber setting for Bool. Disable tests on Linux because of a bug in CFNumberGetType

* Kitura/Kitura#529 Remove xcodeproj that was added by mistake

* Kitura/Kitura#529 Remove xcworkspace as well

* Kitura/Kitura#529 Remove debug printing, fix indentation
@shmuelk
Copy link
Collaborator

shmuelk commented Jul 25, 2016

Reviewed and merged the PR.

@shmuelk shmuelk closed this as completed Jul 25, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.24
Development

No branches or pull requests
5 participants
@dfirsht @shmuelk @vadimeisenbergibm @irar2 @NikitaSullivan