Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Set the minimum required CMake version to 3.10.2. #78

Closed
wants to merge 1 commit into from
Closed

COMP: Set the minimum required CMake version to 3.10.2. #78

wants to merge 1 commit into from

Conversation

jhlegarreta
Copy link
Contributor

As agreed in:
https://discourse.itk.org/t/cmake-update/870/

Set the cmake_minimum_required to version 3.10.2.

@jhlegarreta
Copy link
Contributor Author

I think the IMMEDIATE option for the CONFIGURE_FILE command was removed as of CMake 3.x so I'd appreciate a review from the knowledgeable people before merging this. Thanks.

It's present here and here.

@jhlegarreta
Copy link
Contributor Author

@bradking @thewtex @cryos The travis CI build failed because it is running a 3.9.2 CMake version. Can the travis CI CMake be updated to match the required version if this topics is to be merged? Thanks !

@thewtex
Copy link
Member

thewtex commented Nov 2, 2018

@jhlegarreta Thanks for the contribution!

The following could get this branch green:

@jhlegarreta jhlegarreta force-pushed the UpdateCMakeMinimumRequiredVersion branch from 086dce0 to ba4021c Compare November 3, 2018 03:47
@jhlegarreta
Copy link
Contributor Author

Done in ba4021c.

@thewtex
Copy link
Member

thewtex commented Nov 5, 2018

:-( looks like it did not work.

Maybe brew install cmake?

@jhlegarreta
COMP: Set the minimum required CMake version to 3.10.2.
1e0fe9f 
As agreed in:
https://discourse.itk.org/t/cmake-update/870/

Set the `cmake_minimum_required` to version **3.10.2**.
@jhlegarreta jhlegarreta force-pushed the UpdateCMakeMinimumRequiredVersion branch from ba4021c to 1e0fe9f Compare November 6, 2018 01:02
@jhlegarreta
Copy link
Contributor Author

Looks like brew is not being recognized as a command 🙄

@hjmjohnson
Copy link
Contributor

Superceeded by #92

@jhlegarreta
Copy link
Contributor Author

Thanks @hjmjohnson ! Closing.

@jhlegarreta jhlegarreta closed this Mar 5, 2020
@jhlegarreta jhlegarreta deleted the UpdateCMakeMinimumRequiredVersion branch March 5, 2020 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jhlegarreta @thewtex @hjmjohnson