Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consistent target and cmake option names. #85

Closed
vibraphone opened this issue Feb 28, 2015 · 0 comments · Fixed by #152
Closed

Consistent target and cmake option names. #85

vibraphone opened this issue Feb 28, 2015 · 0 comments · Fixed by #152
Milestone
CMB RC1

Comments

@vibraphone
Copy link
Member

SMTK's libraries and CMake options are not named consistently.

  • All of the session *_Plugin libraries should be *Plugin (no underscore).
  • All of the support libraries should be named SMTKXXX, not smtkXXX or xxxSMTK
    • QtSMTK → SMTKQt
    • cgmSMTK → SMTKCGMSession
    • cgmSMTKPython → SMTKCGMSessionPython
    • smtkDiscreteSession → SMTKDiscreteSession
    • smtkDiscreteSessionPython → SMTKDiscreteSessionPython
    • SMTKSessionExodus → SMTKExodusSession
    • SMTKSessionExodusPython → SMTKExodusSessionPython
    • SMTKRemotePython → SMTKRemoteSessionPython
    • SMTKRemote → SMTKRemoteSession
  • All of the CMake configuration options should be named consistently.
    • SMTK_BUILD_QT → SMTK_ENABLE_QT_SUPPORT
    • SMTK_BUILD_VTK → SMTK_ENABLE_VTK_SUPPORT
    • SMTK_BUILD_CGM → SMTK_ENABLE_CGM_SESSION
    • SMTK_BUILD_SESSION_PLUGIN → SMTK_ENABLE_PARAVIEW_SUPPORT
    • SMTK_ENABLE_REMUS → SMTK_ENABLE_REMOTE_SESSION (or perhaps in addition to SMTK_ENABLE_REMUS_SUPPORT if mesh workers will also be included).
    • SMTK_BUILD_MOAB_READER → SMTK_ENABLE_MOAB_SUPPORT
    • SMTK_BUILD_DISCRETE_SESSION → SMTK_ENABLE_DISCRETE_SESSION
    • SMTK_BUILD_CGM → SMTK_ENABLE_CGM_SESSION
@vibraphone vibraphone added this to the 0.5 milestone Feb 28, 2015
vibraphone added a commit to vibraphone/SMTK that referenced this issue Apr 21, 2015
@vibraphone
Progress on Kitware#85 (consistent target + option names).
194ef9c 
This patch includes the following changes:

+ Eliminate a shiboken warning (do not wrap cJSON methods).
+ Fix a stupid mistake causing a warning in ExportJSON.
+ A scripted rename. Ran this command:

      find smtk/bridge -type f -exec vim -S /path/to/vscr {} \;

  where `vscr` contained

      %s/SMTKSessionExodusExports/Exports/g
      %s/SMTKSessionExodus/smtkExodusSession/g
      %s/SMTKSESSIONEXODUS_EXPORT/SMTKEXODUSSESSION_EXPORT/g
      %s/discreteSessionExports/Exports/g
      %s/SMTKRemoteExports/Exports/g
      %s/SMTKRemote/smtkRemoteSession/g
      %s/SMTKREMOTE_EXPORT/SMTKREMOTESESSION_EXPORT/g
      wq
+ Another scripted rename:

      find smtk/extension -type f -exec vim -S /path/to/vscr {} \;

  where `vscr` is a vim script containing:

      %s/QtSMTKExports.h/Exports.h/g
      %s/QTSMTK_EXPORT/SMTKQTEXT_EXPORT/g
      %s/vtkSMTKModule/smtkVTKExtModule/g
      %s/vtkSMTKExports/smtkVTKExtExports/g
      %s/VTKSMTK_EXPORT/SMTKVTKEXT_EXPORT/g
      %s/vtkSMTK/smtkVTKExt/g
      wq

+ Add VTK-style Python wrapping to the classes in vtkSMTKExt
  (which cannot be named smtkVTKExt because of VTK's build system).
+ Fixes to get things building again.
vibraphone added a commit to vibraphone/SMTK that referenced this issue Apr 21, 2015
@vibraphone
Rename options (issue Kitware#85).
8da40fc 
This included an automated rename:

    find * -type f -exec vim -S /path/to/vscr {} \;

where `vscr` contained

    %s/SMTK_BUILD_QT/SMTK_ENABLE_QT_SUPPORT/g
    %s/SMTK_BUILD_VTK/SMTK_ENABLE_VTK_SUPPORT/g
    %s/SMTK_BUILD_CGM/SMTK_ENABLE_CGM_SESSION/g
    %s/SMTK_BUILD_SESSION_PLUGIN/SMTK_ENABLE_PARAVIEW_SUPPORT/g
    %s/SMTK_BUILD_MOAB_READER/SMTK_ENABLE_MOAB_SUPPORT/g
    %s/SMTK_BUILD_DISCRETE_SESSION/SMTK_ENABLE_DISCRETE_SESSION/g
    %s/SMTK_BUILD_CGM/SMTK_ENABLE_CGM_SESSION/g
    %s/SMTK_BUILD_PYTHON_WRAPPINGS/SMTK_ENABLE_PYTHON_WRAPPING/g
    wq
vibraphone added a commit to vibraphone/SMTK that referenced this issue Apr 21, 2015
@vibraphone
Progress on Kitware#85 (consistent target + option names).
eaf2484 
This patch includes the following changes:

+ Eliminate a shiboken warning (do not wrap cJSON methods).
+ Fix a stupid mistake causing a warning in ExportJSON.
+ A scripted rename. Ran this command:

      find smtk/bridge -type f -exec vim -S /path/to/vscr {} \;

  where `vscr` contained

      %s/SMTKSessionExodusExports/Exports/g
      %s/SMTKSessionExodus/smtkExodusSession/g
      %s/SMTKSESSIONEXODUS_EXPORT/SMTKEXODUSSESSION_EXPORT/g
      %s/discreteSessionExports/Exports/g
      %s/SMTKRemoteExports/Exports/g
      %s/SMTKRemote/smtkRemoteSession/g
      %s/SMTKREMOTE_EXPORT/SMTKREMOTESESSION_EXPORT/g
      wq
+ Another scripted rename:

      find smtk/extension -type f -exec vim -S /path/to/vscr {} \;

  where `vscr` is a vim script containing:

      %s/QtSMTKExports.h/Exports.h/g
      %s/QTSMTK_EXPORT/SMTKQTEXT_EXPORT/g
      %s/vtkSMTKModule/smtkVTKExtModule/g
      %s/vtkSMTKExports/smtkVTKExtExports/g
      %s/VTKSMTK_EXPORT/SMTKVTKEXT_EXPORT/g
      %s/vtkSMTK/smtkVTKExt/g
      wq

+ Add VTK-style Python wrapping to the classes in vtkSMTKExt
  (which cannot be named smtkVTKExt because of VTK's build system).
  This should close Kitware#97.
+ Fixes to get things building again.
vibraphone added a commit to vibraphone/SMTK that referenced this issue Apr 21, 2015
@vibraphone
Rename options (issue Kitware#85).
f2df704 
This included an automated rename:

    find * -type f -exec vim -S /path/to/vscr {} \;

where `vscr` contained

    %s/SMTK_BUILD_QT/SMTK_ENABLE_QT_SUPPORT/g
    %s/SMTK_BUILD_VTK/SMTK_ENABLE_VTK_SUPPORT/g
    %s/SMTK_BUILD_CGM/SMTK_ENABLE_CGM_SESSION/g
    %s/SMTK_BUILD_SESSION_PLUGIN/SMTK_ENABLE_PARAVIEW_SUPPORT/g
    %s/SMTK_BUILD_MOAB_READER/SMTK_ENABLE_MOAB_SUPPORT/g
    %s/SMTK_BUILD_DISCRETE_SESSION/SMTK_ENABLE_DISCRETE_SESSION/g
    %s/SMTK_BUILD_CGM/SMTK_ENABLE_CGM_SESSION/g
    %s/SMTK_BUILD_PYTHON_WRAPPINGS/SMTK_ENABLE_PYTHON_WRAPPING/g
    wq
@vibraphone vibraphone mentioned this issue Apr 21, 2015
Merged
vibraphone added a commit that referenced this issue Apr 21, 2015
@vibraphone
Merge pull request #152 from vibraphone/name-changes
241e3e0 
Name changes to address #85.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
CMB RC1
Development

Successfully merging a pull request may close this issue.

Name changes to address #85. vibraphone/SMTK
1 participant
@vibraphone