Make it possible to delete workflow connections #93
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This addresses #82 |
| path.on("click", function (d) { | ||
| var r = confirm("Remove this connection from this workflow?"); | ||
| if (r === true) { | ||
| d3.select(this).remove(); |
There was a problem hiding this comment.
Something else needs to happen here to delete the connection from the "model", this only deletes it from the "view". You need to find the connection in the workflow.connections list and remove it. You can see the bug if you delete a connection then save the workflow - the connections will reappear when the view is reset.
|
Thanks for catching this. I'll look into it & push a new commit to this PR shortly. |
not just the view
zackgalbreath
added a commit
that referenced
this pull request
Feb 19, 2015
Make it possible to delete workflow connections
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.