Convert and refactor Ceres optimize_cameras test #379
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add an additional test helper to compare Eigen matrices in case of sign ambiguity. This is the same as EXPECT_MATRIX_NEAR, but will also accept matrices that are otherwise within tolerance but differ by sign. (This handles some cases where matrices differing only by sign are still functionally equivalent, and allows us refactor some spots that had extra logic to deal with such cases.)
Convert Ceres optimize_cameras test to Google Test. Factor out test cases that are shared with the VXL optimize_cameras test into a helper header.
|
Linux build succeeded: https://open.cdash.org/buildSummary.php?buildid=5142068 |
|
Mac build failure: https://open.cdash.org/buildSummary.php?buildid=5142104 |
|
Windows build failure: https://open.cdash.org/buildSummary.php?buildid=5144116 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add additional test helper to compare Eigen in case of sign ambiguity (see 1b7163c for details). Convert Ceres
optimize_camerastest to Google Test. Factor out test cases that are shared with the VXLoptimize_camerastest into a helper header.