Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass parameter --proxies to pvpython #40

Closed
wants to merge 0 commits into from
Closed

Conversation

wgui1
Copy link

@wgui1 wgui1 commented Aug 17, 2017

to be able to customize reader and filter, it needs to use --proxies
#35

@jourdain
Copy link
Collaborator

Thanks @wgui for your contribution and your fix is exactly what needs to be done.

But could you do 2 things:

  1. remove the change you've made on dist/Visualizer.js since that should not have changed.
  2. Edit your commit message to follow
    -- Or just use that one: fix(cli): Add support for --proxies argument

@jourdain
Copy link
Collaborator

Your change didn't get through... Are you going to push something else?

@wgui1
Copy link
Author

wgui1 commented Aug 17, 2017

sorry, didn't notice it is closed. I will try another pull request
I am following the guide to use git cz

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants