Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Regression between version 13.18.0 and 13.18.1 #1493

Closed
xavArtley opened this issue Jun 16, 2020 · 6 comments
Closed

Regression between version 13.18.0 and 13.18.1 #1493

xavArtley opened this issue Jun 16, 2020 · 6 comments

Comments

@xavArtley
Copy link

xavArtley commented Jun 16, 2020

Hello,

I think it will be hard to debug and I'll try to add as much as information its needs but I experience a regression under panel python library which are related to changes introduced by version 13.18.1

panel serialize a python vtkRenderWindow and use vtk.js synchronizableRenderWindow to reconstruct it and display the vtk scene in the browser.

However on panel side we developped some utilities as the possibility to add an orientationWidget in the scene.

Everthing worked well until version 13.18.1 where the following error appeared.

Uncaught (in promise) TypeError: Cannot read property 'offset' of null
    at Object.e.setMapperShaderParameters (VM273 vtk.js:282)
    at Object.e.updateShaders (VM273 vtk.js:282)
    at Object.e.renderPieceDraw (VM273 vtk.js:282)
    at Object.e.renderPiece (VM273 vtk.js:282)
    at Object.e.render (VM273 vtk.js:282)
    at e.opaquePass (VM273 vtk.js:282)
    at Object.e.apply (VM273 vtk.js:282)
    at Object.e.traverse (VM273 vtk.js:282)
    at e.traverseOpaquePass (VM273 vtk.js:282)
    at Object.e.traverse (VM273 vtk.js:282)

As long as I don't add objects on javascript side and stick to rendering the serialized scene everithing run smoothly.
It's the mix of both serialize scene and other actor added on javascript side directly wich make the error occur

@boucaud
Copy link
Contributor

boucaud commented Jun 16, 2020

Hello,

Do you have more details on the way this orientation widget is created ? The example seems to work as expected.
Thanks !

@xavArtley
Copy link
Author

xavArtley commented Jun 16, 2020

The error occur only when a scene is updated in the vtkSynchronizableRenderWindow

Here is an example of the error in action
ezgif com-video-to-gif (8)

First I create a renderWindow with a only a Cone and I an orientation widget is added on javascript side:
The python scene is serialized and passed to javascript side (everything is working)

Then I add a Sphere to the scene and I synchronize with javascipt side and the error occur

@xavArtley
Copy link
Author

I tried to put a reproducible example

It's not well coded it's just a bunch of copy past but it allows to reproduce the error:
https://drive.google.com/file/d/1M9aLkFTDk20DnqLM7J5azrs-vrae8Q0i/view?usp=sharing

ezgif com-video-to-gif (10)

@boucaud
Copy link
Contributor

boucaud commented Jun 18, 2020

Thank you for your example. I will try to check as soon as I can

@jourdain
Copy link
Collaborator

Thanks @boucaud for looking into it.

@jourdain
Copy link
Collaborator

If this is still an issue, please re-open.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants