Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTK] Remove orientation widget interactivity to update vtkjs version #1602

Closed
xavArtley opened this issue Sep 25, 2020 · 1 comment
Closed
Labels
type: discussion Requiring community discussion

Comments

@xavArtley
Copy link
Collaborator

For the moment I can't update vtkjs version mainly related to these issues:
Kitware/vtk-js#1493
Kitware/vtk-js#1381

However if I remove the interactivity of the orientation widget, it is not a problem anymore
The interactivity of orientation widget allow to set the XY, YZ or XZ view but we could provide other ways to achieve this behavior (trigger a callback with a variable change for example)

@jbednar, @philippjfr
Do you think it's legitimate to remove the interactive behavior of the orientation for future panel version?
Being able to update the vtk.js version will simplify the integration of future improvements

@xavArtley xavArtley added TRIAGE Default label for untriaged issues type: discussion Requiring community discussion and removed TRIAGE Default label for untriaged issues labels Sep 25, 2020
@xavArtley xavArtley changed the title Update vtkjs version [VTK] Remove orientation widget interactivity to update vtkjs version Sep 25, 2020
@philippjfr
Copy link
Member

I'd be in favor of removing that interactivity, at least temporarily, if it allows us to upgrade vtkjs versions. Would be great to restore it later but for now I favor compatibility over this feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: discussion Requiring community discussion
Projects
None yet
Development

No branches or pull requests

2 participants