Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[VTK] add vtkFollower #1451

Merged
merged 3 commits into from
Jun 25, 2020
Merged

[VTK] add vtkFollower #1451

merged 3 commits into from
Jun 25, 2020

Conversation

xavArtley
Copy link
Collaborator

@xavArtley xavArtley commented Jun 22, 2020

Implement and fix #1412
I had to port Kitware/vtk-js#1511 into panel vtk models because until Kitware/vtk-js#1493 is solved I can't update vtk-js version
Peek 23-06-2020 00-21

  • : tests
  • : deserializer

@xavArtley xavArtley changed the title add vtkFollower [VTK] add vtkFollower Jun 22, 2020
@codecov
Copy link

codecov bot commented Jun 22, 2020

Codecov Report

Merging #1451 into master will increase coverage by 0.01%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1451      +/-   ##
==========================================
+ Coverage   87.78%   87.79%   +0.01%     
==========================================
  Files         135      135              
  Lines       14930    14946      +16     
==========================================
+ Hits        13106    13122      +16     
  Misses       1824     1824              
Impacted Files Coverage Δ
panel/pane/vtk/synchronizable_deserializer.py 97.50% <100.00%> (ø)
panel/pane/vtk/synchronizable_serializer.py 84.70% <100.00%> (+0.23%) ⬆️
panel/tests/pane/test_vtk.py 98.23% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 295ce22...b8e38d0. Read the comment docs.

@philippjfr
Copy link
Member

Looks good to me! Thanks @xavArtley.

@philippjfr philippjfr merged commit cd2c99f into master Jun 25, 2020
@philippjfr philippjfr deleted the xav/vtk_follower branch June 25, 2020 22:03
@GilShoshan94
Copy link

Looks amazing !!!
Thank you ! @xavArtley @jourdain @philippjfr

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

VTK - vtkFollower don't follow the camera in Panel
3 participants