Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(WebGPU): add actor matrix support #1891

Merged
merged 1 commit into from
May 4, 2021
Merged

Conversation

martinken
Copy link
Member

Should now handle actor matrices. Also by default performs
shifting into to handle floating point resolution issues.

Moved a test from OpenGL to Core as it didn't need OpenGL

Should now handle actor matrices. Also by default performs
shifting into to handle floating point resolution issues.

Moved a test from OpenGL to Core as it didn't need OpenGL
@@ -20,15 +20,47 @@ The coordinate systems in vtk are as follows:

POSE - world coords translated and rotated to the camera position and view direction

STABILIZED - used by rendering backends to deal with floating point resolution issues. Similar to world coordinates but with a translation to try to get the
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

api.md are now generated (which mean we should start removing them from the repo).

The documentation should be added in the TypeScript file instead.

Copy link
Collaborator

@jourdain jourdain May 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@daker is that true that the api.md are now auto-generated? If so, should we start removing them to prevent any confusion?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation needs to go in .d.ts file if it's present otherwise it needs to go in api.md, i will remove the api.md from folders where we have the .d.ts, i'll make a PR to cleanup this and sorry about the confusion.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np, I just wanted to make sure. Can you grab the doc that Ken added here and put it inside the ts?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, i'll fix that.

@martinken martinken merged commit 00c3548 into master May 4, 2021
@jourdain jourdain deleted the webgpu_actor_matrix branch May 4, 2021 18:10
@github-actions
Copy link

github-actions bot commented May 4, 2021

🎉 This PR is included in version 17.17.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@github-actions github-actions bot added the released Automated label label May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Automated label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants