-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(WebGPU): add actor matrix support #1891
Conversation
Should now handle actor matrices. Also by default performs shifting into to handle floating point resolution issues. Moved a test from OpenGL to Core as it didn't need OpenGL
49127eb
to
6b22f41
Compare
@@ -20,15 +20,47 @@ The coordinate systems in vtk are as follows: | |||
|
|||
POSE - world coords translated and rotated to the camera position and view direction | |||
|
|||
STABILIZED - used by rendering backends to deal with floating point resolution issues. Similar to world coordinates but with a translation to try to get the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
api.md are now generated (which mean we should start removing them from the repo).
The documentation should be added in the TypeScript file instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@daker is that true that the api.md are now auto-generated? If so, should we start removing them to prevent any confusion?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Documentation needs to go in .d.ts file if it's present otherwise it needs to go in api.md, i will remove the api.md from folders where we have the .d.ts, i'll make a PR to cleanup this and sorry about the confusion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
np, I just wanted to make sure. Can you grab the doc that Ken added here and put it inside the ts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sure, i'll fix that.
🎉 This PR is included in version 17.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Should now handle actor matrices. Also by default performs
shifting into to handle floating point resolution issues.
Moved a test from OpenGL to Core as it didn't need OpenGL