-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(WidgetManager): handle touch support #2506
Conversation
LGTM |
There is still a performance issue when multiple widget managers exist in a render window. |
Some of the performance issues stem from #2484. I have a fix for that, which should benefit this PR. Update: that performance gain was only for a very specific test. Still getting some slowness with multiple widget managers. |
c81e516
to
052364b
Compare
740a959
to
520c12d
Compare
I think this is good to go. I've tested this on a Chromium-based browser on a smartphone using a polyline wiget example that has been modified to include the orientation marker widget. |
520c12d
to
c28e4eb
Compare
I've updated the PR with the following changes:
|
c28e4eb
to
3afd98e
Compare
3afd98e
to
0989684
Compare
@finetjul can I get one more review? I'm set with this implementation, since it should work without getting into the weeds on asyncifying the event handling. |
0989684
to
dec2e93
Compare
LGTM |
convert() is a hot function, so avoid allocating/GC of the rgb array.
This adds functionality to only process the latest selection request.
dec2e93
to
ffa5989
Compare
🎉 This PR is included in version 25.8.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Hello, I have a stl file that renders and when I add a widget the movement is frozen, I can't move the stl file and zoom it. |
Context
FYI @finetjul. I'm still investigating, but here is something that might work.
Results
Changes
PR and Code Checklist
npm run reformat
to have correctly formatted codeTesting