Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: add example for resampling transformed images to be axis aligned #38

Merged
merged 9 commits into from Jun 29, 2021

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Mar 26, 2021

No description provided.

@dzenanz dzenanz requested a review from thewtex March 26, 2021 21:35
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We do not want to use non-orthogonal bases in the Direction matrix.

Instead this should

  • Use ImageSpatialObject to define the sampling grid for the output. Use the Transform to move the ImageSpatialObject.
  • Be written in Python

@dzenanz dzenanz force-pushed the axisAligned branch 2 times, most recently from f23b760 to 93f0458 Compare April 6, 2021 18:36
@dzenanz dzenanz force-pushed the axisAligned branch 3 times, most recently from cafe58a to 358147f Compare April 14, 2021 21:53
Data/axisAlignedResample.cmd Outdated Show resolved Hide resolved
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@dzenanz dzenanz requested a review from thewtex June 29, 2021 19:53
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔢 🐍 👍

@dzenanz dzenanz merged commit fdedee9 into KitwareMedical:master Jun 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants