ENH: Template mesh generation #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
thewtex
reviewed
Apr 5, 2021
tbirdso
force-pushed
the
iterative-mean-mesh
branch
4 times, most recently
from
83e2281
to
a0e1c17
Compare
tbirdso
force-pushed
the
iterative-mean-mesh
branch
from
a0e1c17
to
ca501fc
Compare
thewtex
reviewed
Apr 16, 2021
| @@ -0,0 +1,1042 @@ | |||
| { | |||
There was a problem hiding this comment.
We should avoid the use of filter for a variable name because it conflicts with the built-in function filter. We can use filt or filter_ or preferably something more specific, e.g. paster in this case.
Reply via ReviewNB
| @@ -0,0 +1,1042 @@ | |||
| { | |||
There was a problem hiding this comment.
We should prefer the snake_case form with the snake case filters, e.g. OutputOrigin -> output_origin.
Reply via ReviewNB
| @@ -0,0 +1,1042 @@ | |||
| { | |||
There was a problem hiding this comment.
Note, the output ends here with a KeyboardInterrupt. In the future, we will want to save the version in the repository with the full output.
Reply via ReviewNB
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add notebook to demonstrate iterative mesh template generation with HASI registrar classes.
Depends on #29.