STYLE: Prefer error checked std::sto[id] over ato[if]. #3
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ato[if]
functions do not provide mechanisms for distinguishingbetween
0
and the error condition where the input can not be converted.std::sto[id]
provides exception handling and detects when an invalidstring attempts to be converted to an [integer|double].
ato[if]()
The use of
ato[if]
in code can cause it to be subtly broken.ato[if]
makes two very big assumptions indeed:In agreement with:
http://review.source.kitware.com/#/c/23738/