Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing wrapping #126

Closed
dzenanz opened this issue Mar 15, 2021 · 5 comments
Closed

Missing wrapping #126

dzenanz opened this issue Mar 15, 2021 · 5 comments
Assignees

Comments

@dzenanz
Copy link
Member

dzenanz commented Mar 15, 2021

From MacOS build log:

[22/44] Generating /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-macosx_x86_64/Wrapping/Typedefs/itkSpectra1DSupportWindowImageFilter.i, /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-macosx_x86_64/Wrapping/Typedefs/itkCurvilinearArraySpecialCoordinatesImage.i, /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-macosx_x86_64/Wrapping/Typedefs/itkFrequencyDomain1DFilterFunction.i, /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-macosx_x86_64/Wrapping/Typedefs/itkFrequencyDomain1DImageFilter.i, /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-macosx_x86_64/Wrapping/Typedefs/itkBModeImageFilter.i, /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-macosx_x86_64/Wrapping/Typedefs/itkButterworthBandpass1DFilterFunction.i, /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-macosx_x86_64/Wrapping/Typedefs/itkSpectra1DImageFilter.i, /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-macosx_x86_64/Wrapping/Typedefs/itkSpectra1DSupportWindowToMaskImageFilter.i, /Users/svc-dashboard/D/P/ITKPythonPackage/ITK-3.6-ma...
itkBModeImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::FrequencyDomain1DImageFilter< itk::CurvilinearArraySpecialCoordinatesImage< std::complex< double >, 2 >, itk::CurvilinearArraySpecialCoordinatesImage< std::complex< double >, 2 > >
itkBModeImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::FrequencyDomain1DImageFilter< itk::Image< std::complex< double >, 2 >, itk::Image< std::complex< double >, 2 > >
itkBModeImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::FrequencyDomain1DImageFilter< itk::Image< std::complex< double >, 3 >, itk::Image< std::complex< double >, 3 > >
itkBModeImageFilter: warning(4): ITK type not wrapped, or currently not known: itk::FrequencyDomain1DImageFilter< itk::Image< std::complex< double >, 4 >, itk::Image< std::complex< double >, 4 > >
@thewtex
Copy link
Member

thewtex commented Mar 24, 2021

Runtime:

Warning: Unknown parameter 'itk::CurvilinearArraySpecialCoordinatesImage<std::complex,2>' in template 'itk::BModeImageFilter'

@dzenanz
Copy link
Member Author

dzenanz commented Apr 7, 2021

I found the reason:

1>CMake Warning at wrapping/CMakeLists.txt:2 (message):
1>  ITK_WRAP_double is on but ITK_WRAP_complex_double is not.  Some filters
1>  with double input / outputs depend on complex filters.  Set
1>  ITK_WRAP_complex_double to on

We turn on double but not complex_double in PythonPackage:
https://github.com/InsightSoftwareConsortium/ITKPythonPackage/blob/v5.2.0/scripts/macpython-build-wheels.sh#L100-L102

@dzenanz
Copy link
Member Author

dzenanz commented Apr 7, 2021

Hopefully, InsightSoftwareConsortium/ITKPythonPackage#157 will solve this.

@thewtex
Copy link
Member

thewtex commented May 23, 2021

@dzenanz addressed?

@dzenanz
Copy link
Member Author

dzenanz commented May 24, 2021

I haven't verified it, but if it wasn't we can reopen any time.

@dzenanz dzenanz closed this as completed May 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants