Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add SSSCI wrapping with Python test and baseline #235

Merged
merged 6 commits into from
Jul 15, 2023
Merged

Add SSSCI wrapping with Python test and baseline #235

merged 6 commits into from
Jul 15, 2023

Conversation

dzenanz
Copy link
Member

@dzenanz dzenanz commented Jul 12, 2023

No description provided.

@dzenanz dzenanz requested a review from tbirdso July 12, 2023 19:34
tbirdso
tbirdso reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far. @dzenanz please ping me when this is ready for formal review.

@dzenanz dzenanz marked this pull request as ready for review July 13, 2023 13:46
@dzenanz
Copy link
Member Author

dzenanz commented Jul 13, 2023

This is ready for review.

tbirdso
tbirdso reviewed Jul 13, 2023
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code LGTM, but we should confirm that tests are validating per-slice transforms as intended.

@dzenanz dzenanz marked this pull request as draft July 13, 2023 15:30
@dzenanz
Copy link
Member Author

dzenanz commented Jul 14, 2023

I will squash some commits and reorder, to have less back and forth.

@dzenanz dzenanz marked this pull request as ready for review July 14, 2023 14:35
thewtex
thewtex approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@thewtex thewtex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nicely done! 💯

@dzenanz
Copy link
Member Author

dzenanz commented Jul 14, 2023

I will merge and tag once the CI finishes (probably late today or tomorrow).

@dzenanz dzenanz merged commit b351ac1 into KitwareMedical:master Jul 15, 2023
31 checks passed
@dzenanz dzenanz deleted the wrapSSSCI branch July 15, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tbirdso tbirdso tbirdso left review comments

@thewtex thewtex thewtex approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dzenanz @thewtex @tbirdso