Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Bump CI for ITK 5.4 RC 01 #237

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

COMP: Bump CI for ITK 5.4 RC 01 #237

wants to merge 1 commit into from

Conversation

thewtex
Copy link
Member

@thewtex thewtex commented Jul 26, 2023

No description provided.

@thewtex thewtex requested review from dzenanz and tbirdso July 26, 2023 22:42
@thewtex thewtex mentioned this pull request Jul 26, 2023
Closed
tbirdso
tbirdso approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@tbirdso tbirdso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI bump looks fine. @thewtex Did you want to bump the itk-ultrasound version as well for a new release?

@thewtex
Copy link
Member Author

thewtex commented Jul 31, 2023

Let's not bump / publish the package version until itk-5.4.0 is out to avoid incompatibilities with dependent packages.

dzenanz
dzenanz approved these changes Jul 31, 2023
View reviewed changes
Copy link
Member

@dzenanz dzenanz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good on a glance.

@dzenanz
Copy link
Member

dzenanz commented Aug 1, 2023

python-build-workflow / build-linux-py (8, _2_28-aarch64)
The job running on runner GitHub Actions 2 has exceeded the maximum execution time of 360 minutes.

I restarted just one job now.

@dzenanz
Copy link
Member

dzenanz commented Aug 3, 2023

After multiple restarts, arm64 builds always time out.

@tbirdso
Copy link
Contributor

tbirdso commented Aug 3, 2023

After multiple restarts, arm64 builds always time out.

Depending on how strong the motive for Python packages is, we may need to look into self-hosting ARM builds with CIRun similar to how we do GPU builds in ITKVkFFTBackend. That would allow us to avoid platform emulation, which tends to be slow. I think it could also remove the hard 6 hour timeout requirement.

I suggest that we remove ARM builds from the list of target platforms for now to allow this update to move forward, and open an issue to track the regression.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dzenanz dzenanz dzenanz approved these changes

@tbirdso tbirdso tbirdso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@thewtex @dzenanz @tbirdso