Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

COMP: Update Main.cxx to explicitly include configure headers for used macros #53

Merged
merged 1 commit into from Jul 13, 2023
Merged

COMP: Update Main.cxx to explicitly include configure headers for used macros #53

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions {{cookiecutter.project_name}}/Applications/{{cookiecutter.app_name}}App/Main.cxx
View file
Open in desktop
Expand Up @@ -22,6 +22,8 @@
// Slicer includes
#include "qSlicerApplication.h"
#include "qSlicerApplicationHelper.h"
#include "vtkSlicerConfigure.h" // For Slicer_MAIN_PROJECT_APPLICATION_NAME
Copy link

@darabi darabi Jul 13, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly necessary, as it is included transitively via

qSlicerApplication.h -> qSlicerCoreApplication.h -> vtkSlicerConfigure.h

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the review 🙏

While it is not strictly required, it is good practice to include headers for classes or macros directly used. It prevents issues if any of the files indirectly included are updated.

#include "vtkSlicerVersionConfigure.h" // For Slicer_MAIN_PROJECT_VERSION_FULL

namespace
{
Expand Down