Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ENH: Add dicom fields scrapping script #62

Merged
merged 1 commit into from Feb 26, 2024
Merged

ENH: Add dicom fields scrapping script #62

merged 1 commit into from Feb 26, 2024

Conversation

pchoisel
Copy link
Collaborator

No description provided.

finetjul
finetjul approved these changes Jan 15, 2024
View reviewed changes
Copy link
Member

@finetjul finetjul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@smjoshiatglobus
Copy link
Contributor

Thank you for doing this!
Just nitpicking... would scrape be a better action verb than scrap for the new file and method?
English is not my first language, and I have made worse mistakes myself, multiple times! I rely on spell-checkers, but they may not catch this one, since both are valid words.

@smjoshiatglobus
Copy link
Contributor

PR #64 should fix (or at least suppress) the unit test failure.

@pchoisel pchoisel merged commit 3ffe350 into KitwareMedical:master Feb 26, 2024
1 check failed
@smjoshiatglobus smjoshiatglobus mentioned this pull request Feb 26, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@finetjul finetjul finetjul approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pchoisel @smjoshiatglobus @finetjul