Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature models #12

Merged
merged 24 commits into from
May 13, 2017
Merged

Feature models #12

merged 24 commits into from
May 13, 2017

Conversation

KleinYuan
Copy link
Owner

  • Allowing users to download/load model with URL

  • Allowing users to delete downloaded models

  • Adding time elapse in live mode

  • Adding time elapse in static mode

  • Reduce some redundant usages of some objects, optimizing the memory for every load

  • Error handling of caffe crash is still not done but not a big blocker

//
// print("Result is \n\(finalResult)")
//
// }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can remove these now

downloadedModelPredictPaths.append(self.predictNetFilePath)
UserDefaults.standard.setValue(downloadedModelNames, forKeyPath: kDownloadedModelNames)
UserDefaults.standard.setValue(downloadedModelInitPaths, forKeyPath: kDownloadedModelInitPaths)
UserDefaults.standard.setValue(downloadedModelPredictPaths, forKeyPath: kDownloadedModelPredictPaths)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add function here so that, as you said, once download is finished, back to previous view so user won't be confused.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

something like
.popViewController(animated: true)

@KleinYuan KleinYuan merged commit 3dd897c into develop May 13, 2017
@KleinYuan KleinYuan deleted the feature-models branch May 13, 2017 19:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants