-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature models #12
Feature models #12
Conversation
move view when keyboard appears
some improvement
// | ||
// print("Result is \n\(finalResult)") | ||
// | ||
// } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can remove these now
downloadedModelPredictPaths.append(self.predictNetFilePath) | ||
UserDefaults.standard.setValue(downloadedModelNames, forKeyPath: kDownloadedModelNames) | ||
UserDefaults.standard.setValue(downloadedModelInitPaths, forKeyPath: kDownloadedModelInitPaths) | ||
UserDefaults.standard.setValue(downloadedModelPredictPaths, forKeyPath: kDownloadedModelPredictPaths) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add function here so that, as you said, once download is finished, back to previous view so user won't be confused.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
something like
.popViewController(animated: true)
Allowing users to download/load model with URL
Allowing users to delete downloaded models
Adding time elapse in live mode
Adding time elapse in static mode
Reduce some redundant usages of some objects, optimizing the memory for every load
Error handling of caffe crash is still not done but not a big blocker