Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[API] Update subgraph version to include UpdatedExpiration event #2245

Merged
merged 8 commits into from
Feb 14, 2024

Conversation

psparacino
Copy link
Collaborator

@psparacino psparacino commented Feb 7, 2024

Description

The listings issue described below appears to be a casing issue in the frontend.

This updates the subgraph (current version breaks on activities query as there are null projects for some entities due to an uncaught case) to handle expiration date only updates.

Related Ticket

Related to #2243

How to Test

  1. got to https://carbonmark-git-tufnel-fix-listings-not-showing-klimadao.vercel.app/users/jabby
  2. confirm expired listings are there

@psparacino psparacino deployed to Preview – carbonmark-api February 7, 2024 01:57 — with GitHub Actions Active
Copy link

vercel bot commented Feb 7, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
carbon ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 0:25am
carbonmark ✅ Ready (Inspect) Visit Preview Feb 13, 2024 0:25am
carbonmark-api ✅ Ready (Inspect) Visit Preview Feb 13, 2024 0:25am
demo-integration ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 0:25am
klimadao-app ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 13, 2024 0:25am

@psparacino psparacino deployed to Preview – carbonmark-api February 7, 2024 02:00 — with GitHub Actions Active
@psparacino psparacino changed the title api: show listings for 90 days after expiration Expired listings not showing Feb 7, 2024
@psparacino psparacino changed the title Expired listings not showing Listings show for 90 days after expiration date Feb 7, 2024
Copy link
Member

@jabby09 jabby09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psparacino expired listings are now showing

listings will show for 90 days after they expire

Don't totally understand this.
Do you mean they will show as expired listing on my Profile page?
Why only for 90 days and what happens after that?

Copy link
Member

@jabby09 jabby09 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psparacino while expired listings are showing still something not quite right

If I Edit an expired listing, it looks like the expiration date is being reset to 90 days from current date, so in this case to 5/7/2024
Screenshot 2024-02-07 at 9 34 11 AM

However, if I don't change anything else and just UPDATE LISTING it kicks off the SUBMIT process and I have to do a MM wallet confirm.

But then I just get spinning "Updating your data..." the the update does not work.
Screenshot 2024-02-07 at 9 35 49 AM

Get this error:
Screenshot 2024-02-07 at 9 37 56 AM

and listing is still showing as expired
Screenshot 2024-02-07 at 9 38 37 AM

Copy link
Collaborator

@0xemc 0xemc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@psparacino @biwano

I'm not sure this fixes the issue. My understanding is that the user should always see their own expired listings even after 90 days.

Can we not just provide a large value for expiresAfter on the call to the api from the consumer (app)

@jabby09
Copy link
Member

jabby09 commented Feb 8, 2024

@psparacino @biwano

I'm not sure this fixes the issue. My understanding is that the user should always see their own expired listings even after 90 days.

Can we not just provide a large value for expiresAfter on the call to the api from the consumer (app)

@0xemc correct this is not completely fixed, Peter is working on it https://discord.com/channels/1135827610434289727/1204433909060730900/1204862568926281848

@psparacino psparacino force-pushed the tufnel/fix-listings-not-showing branch from 11f59ef to e0d8124 Compare February 12, 2024 16:26
@psparacino psparacino deployed to Preview – carbonmark-api February 12, 2024 16:26 — with GitHub Actions Active
@psparacino psparacino changed the title Listings show for 90 days after expiration date [API] Update subgraph version to include UpdatedExpiration event Feb 12, 2024
@0xemc
Copy link
Collaborator

0xemc commented Feb 13, 2024

@jabby09 @0xtapi can we give this PR the greenlight?

@jabby09
Copy link
Member

jabby09 commented Feb 13, 2024

@jabby09 @0xtapi can we give this PR the greenlight?

hey @0xemc I believe this is working now but I'm doing some final FE testing on this PR #2255

@psparacino
Copy link
Collaborator Author

@jabby09 The reverting calls on those expired listing occurred because those listings had actually already been deleted by the contract due to having less than the minimum fill amount. There was no event emitted so the subgraph didn't pick it up. The issue was fixed and new events emitted to update the subgraph so that should be separate from this issue

@0xemc 0xemc merged commit fe35a71 into staging Feb 14, 2024
11 checks passed
@0xemc 0xemc deleted the tufnel/fix-listings-not-showing branch February 14, 2024 09:42
@0xemc
Copy link
Collaborator

0xemc commented Feb 14, 2024

Closing after ticks from all parties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

4 participants