-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[API] Update subgraph version to include UpdatedExpiration
event
#2245
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psparacino expired listings are now showing
listings will show for 90 days after they expire
Don't totally understand this.
Do you mean they will show as expired listing on my Profile page?
Why only for 90 days and what happens after that?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psparacino while expired listings are showing still something not quite right
If I Edit an expired listing, it looks like the expiration date is being reset to 90 days from current date, so in this case to 5/7/2024
However, if I don't change anything else and just UPDATE LISTING it kicks off the SUBMIT process and I have to do a MM wallet confirm.
But then I just get spinning "Updating your data..." the the update does not work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure this fixes the issue. My understanding is that the user should always see their own expired listings even after 90 days.
Can we not just provide a large value for expiresAfter on the call to the api from the consumer (app)
@0xemc correct this is not completely fixed, Peter is working on it https://discord.com/channels/1135827610434289727/1204433909060730900/1204862568926281848 |
f5f16b0
to
1db3165
Compare
16c1642
to
ad473be
Compare
11f59ef
to
e0d8124
Compare
UpdatedExpiration
event
@jabby09 The reverting calls on those expired listing occurred because those listings had actually already been deleted by the contract due to having less than the minimum fill amount. There was no event emitted so the subgraph didn't pick it up. The issue was fixed and new events emitted to update the subgraph so that should be separate from this issue |
Closing after ticks from all parties |
Description
The listings issue described below appears to be a casing issue in the frontend.
This updates the subgraph (current version breaks on activities query as there are null projects for some entities due to an uncaught case) to handle expiration date only updates.
Related Ticket
Related to #2243
How to Test