Add creality-ender3s1 config example #5203
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2.add stm32h723 mcu 3.add stm32f401 boot index
1.Add creality-ender3s1 config example 2.add stm32h723 boot config 3.add stm32f401 boot config
fix some tab character
|
I have klipper nicely running on a Ender 3 S1. Do you want my config to compare. The x and y position_max in your file are to high (235) my printer only goes to 228. And the z position_max in your file is a lot lower (250) than I have (270). |
|
Hi
XY position_max 228 can printing 235 is running over bed size,z position_max can running 270,but when you home z,the z axis first lift 10mm, so 260 maybe better
…--
At 2022-02-02 05:23:40, "RobRobM" ***@***.***> wrote:
I have klipper nicely running on a Ender 3 S1. Do you want my config to compare. The x and y position_max in your file are to high (235) my printer only goes to 228. And the z position_max in your file is a lot lower (250) than I have (270).
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you authored the thread.Message ID: ***@***.***>
|
ld3300
suggested changes
Feb 12, 2022
There was a problem hiding this comment.
Hello @KimRay2015,
Please add Signed-off-by:
Please consider the following changes to have your example config follow the repo standards. All configuration settings that are not specific to the board should be removed.
- remove lines 13-15 as the reference to fluidd and the virtual_sdcard are not printer specific.
- remove the entire [gcode_macro PAUSE] section
- remove [gcode_macro RESUME]
- remove [gcode_macro CANCEL_PRINT]
- lines 115-117, remove references to bltouch unless they come as an option when purchasing the printer
- Remove line 125, max_extruder_only_distance. This should be left at the default unless the specific user wants to change it
- Line 179 restore or remove probe section depending on what probe comes stock
- Line 187, remove filament sensor unless it comes stock
- remove lines 191 through 195 as not printer specific
- Line 197, remove unless bltouch comes stock
- Line 214 remove bed_mesh, as this is not a machine specific section
- Line 223 remove G29 section
|
OK,
Thanks for your suggestion;
At 2022-02-12 10:50:20, "David Smith" ***@***.***> wrote:
@ld3300 requested changes on this pull request.
Hello @KimRay2015,
Please add Signed-off-by:
Please consider the following changes to have your example config follow the repo standards. All configuration settings that are not specific to the board should be removed.
-remove lines 13-15 as the reference to fluidd and the virtual_sdcard are not printer specific.
-remove the entire [gcode_macro PAUSE] section
-remove [gcode_macro RESUME]
-remove [gcode_macro CANCEL_PRINT]
lines 115-117, remove references to bltouch unless they come as an option when purchasing the printer
Remove line 125, max_extruder_only_distance. This should be left at the default unless the specific user wants to change it
Line 179 restore or remove probe section depending on what probe comes stock
Line 187, remove filament sensor unless it comes stock
remove lines 191 through 195 as not printer specific
Line 197, remove unless bltouch comes stock
Line 214 remove bed_mesh, as this is not a machine specific section
Line 223 remove G29 section
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
fix error for PI8 not config error
merge klippermaster
|
hm because the requests did not get merged thats again a doubled request ... i did already over a month but get closed because "inactivity" .... |
system auto build have some error ,not modfied by me ,so no merge |
i meant my request did not get merged .... #5097 and there are no errors ... :) but need to wait until @KevinOConnor could merge mine... :) |
|
ok
…---- Replied mail ----
| From | ***@***.***> |
| Date | 02/24/2022 17:35 |
| To | ***@***.***> |
| Cc | ***@***.******@***.***> |
| Subject | Re: [Klipper3d/klipper] Add creality-ender3s1 config example (PR #5203) |
hm because the requests did not get merged thats again a doubled request ... i did already over a month but get closed because "inactivity" ....
system auto build have some error ,not modfied by me ,so no merge
i meant my request did not get merged .... #5097 and there are no errors ... :) but need to wait until @KevinOConnor could merge mine... :)
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
Thanks. I'm not sure what the state of this PR is. I don't understand the changes to src/stm32/Kconfig. It seems those changes (if intentional) should be in separate commits though. -Kevin |
|
OK thanks
…---- Replied mail ----
| From | ***@***.***> |
| Date | 03/15/2022 00:45 |
| To | ***@***.***> |
| Cc | ***@***.******@***.***> |
| Subject | Re: [Klipper3d/klipper] Add creality-ender3s1 config example (PR #5203) |
Thanks. I'm not sure what the state of this PR is. I don't understand the changes to src/stm32/Kconfig. It seems those changes (if intentional) should be in separate commits though.
-Kevin
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
|
some one has a error ,in this case my commit not test pass,how can i handle this error ?
thanks;
-Kim
At 2022-03-14 23:45:55, "KevinOConnor" ***@***.***> wrote:
Thanks. I'm not sure what the state of this PR is. I don't understand the changes to src/stm32/Kconfig. It seems those changes (if intentional) should be in separate commits though.
…-Kevin
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications on the go with GitHub Mobile for iOS or Android.
You are receiving this because you were mentioned.Message ID: ***@***.***>
|
ciaagent
reviewed
May 1, 2022
| @@ -0,0 +1,143 @@ | |||
| # This file contains pin mappings for the Creality CR6-SE with Rev. 4.5.3 Motherboard (Late 2020/2021) as the heater pins changed. | |||
There was a problem hiding this comment.
Ender 3 S1 but it looks like he just copy pasted the config from the CR6-SE
This pull request was closed.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
1.Add creality-ender3s1 config example
2.add stm32h723 boot config
3.add stm32f401 boot config