Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ender 3 S1/S1 Pro Default Configurations #5332

Merged
merged 21 commits into from May 23, 2022
Merged

Ender 3 S1/S1 Pro Default Configurations #5332

merged 21 commits into from May 23, 2022

Conversation

Fisheiyy
Copy link
Contributor

@Fisheiyy Fisheiyy commented Mar 7, 2022

I forked #5097 because #5203 seemed to be setup in a similar way to a personal config and also the fact that other things were included with that PR, but I have updated the Ender 3 S1 config to better suit how it would come configured on Marlin which the printer ships with.

Signed-off-by: Rob Casper myallneedsemail@gmail.com

I deleted the repository that #5287 was on because it was a fork of a fork and so I was not getting the commits that official klipper was, so it was not update to date
@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented Mar 7, 2022

@ld3300 If you could please review this PR due to the changes since your last review on #5287 and also so that there is a review on this new PR.

@Fisheiyy Fisheiyy changed the title Ender 3 S1 Default Configuration Ender 3 S1 Default Configurations Mar 16, 2022
@Fisheiyy
Copy link
Contributor Author

@KevinOConnor if you could look over my PR please.

@KevinOConnor
Copy link
Collaborator

Thanks. In general it looks fine to me. However, the s1pro config example has a copy-and-paste error in the description on the first 2 lines of the file (it says 2021 s1).

Also, it would be preferable to inspect the hardware to find the extruder gear_ratio (see https://www.klipper3d.org/Example_Configs.html point 7e).

-Kevin

@KevinOConnor KevinOConnor added the pending feedback Topic is pending feedback from submitter label Mar 18, 2022
@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented Mar 18, 2022

Thanks. In general it looks fine to me. However, the s1pro config example has a copy-and-paste error in the description on the first 2 lines of the file (it says 2021 s1).

Also, it would be preferable to inspect the hardware to find the extruder gear_ratio (see https://www.klipper3d.org/Example_Configs.html point 7e).

-Kevin

Alright, all done and fixed, I completely forgot about the compilation text in the pro config, Also if my PR gets merged shouldn't that mean that #5097 and #5203 since they are basically the same thing?

@KevinOConnor
Copy link
Collaborator

I'm not sure where you got the gear_ratio from, but it's definitely incorrect. See the description at https://www.klipper3d.org/Rotation_Distance.html . A change to gear_ratio requires a corresponding change to rotation_distance.

-Kevin

@Fisheiyy
Copy link
Contributor Author

I'm not sure where you got the gear_ratio from, but it's definitely incorrect. See the description at https://www.klipper3d.org/Rotation_Distance.html . A change to gear_ratio requires a corresponding change to rotation_distance.

-Kevin

Oops, I forgot about that, the gear ratio is just listed on the creality page for the Ender 3 S1 and is the same on both the pro and non pro

@KevinOConnor
Copy link
Collaborator

I'm not sure where the disconnect is, but the rotation_distance and gear_ratio is definitely incorrect now. As per https://www.klipper3d.org/Example_Configs.html point 7e, the goal is for the rotation_distance to correspond to the circumference of the metal wheel that pushes the filament - it should be a value roughly between 20 and 35. The printer clearly has a gearing mechanism - the best way to figure it out is to look at the gears on the extruder and count the number of teeth on them.

-Kevin

@Fisheiyy
Copy link
Contributor Author

I'm not sure where the disconnect is, but the rotation_distance and gear_ratio is definitely incorrect now. As per https://www.klipper3d.org/Example_Configs.html point 7e, the goal is for the rotation_distance to correspond to the circumference of the metal wheel that pushes the filament - it should be a value roughly between 20 and 35. The printer clearly has a gearing mechanism - the best way to figure it out is to look at the gears on the extruder and count the number of teeth on them.

-Kevin

That makes more sense, I dont physically have a reference but just based on some pictures it looks like it has 20 teeth or so, should I therefore change the rotation distance to 20?

@burtsie
Copy link

burtsie commented Mar 24, 2022

the gear ratio is reversed, it is 1:3.5 and believe it should be 3.5:1

With the gear ratio corrected my ballpark rotation distance is 26 on the stock sprite extruder

Also helpful to to add position_min: -3 under [stepper_z] to not run into out of range when calibrating z offset

@Fisheiyy
Copy link
Contributor Author

@KevinOConnor does this look better?

@KevinOConnor
Copy link
Collaborator

Thanks for working on this. However, the extruder config settings are still obviously incorrect. It seems to me that you are "guessing" on the config, and not testing the resulting config. That consumes our time and raises concerns about the overall quality of the submission.

Setting the extruder gear_ratio is not a requirement. (Using a gear_ratio where appropriate is preferable as it provides more context to the rotation_distance setting - that value is then the circumference of the wheel pushing the filament - but that convention is not a requirement.) Careful testing of a config is a requirement.

-Kevin

@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented Apr 8, 2022

Thanks for working on this. However, the extruder config settings are still obviously incorrect. It seems to me that you are "guessing" on the config, and not testing the resulting config. That consumes our time and raises concerns about the overall quality of the submission.

Setting the extruder gear_ratio is not a requirement. (Using a gear_ratio where appropriate is preferable as it provides more context to the rotation_distance setting - that value is then the circumference of the wheel pushing the filament - but that convention is not a requirement.) Careful testing of a config is a requirement.

-Kevin

Should I put it back to what it was before at the 7.3 i think it was with no gear ratio? I really cant test the config as I don't have an E3 S1 but my friend is getting one soon and I might be able to get him to test for me but im not sure yet.

@jakep82
Copy link

jakep82 commented Apr 8, 2022

You need to test this on actual hardware, or find others with this printer to test it on theirs before submitting a PR. Something as simple as an incorrect motor direction can lead to a new user crashing their print head. Testing on actual hardware will also make it possible to verify the correct gear_ratio and rotation_distance rather than inaccurate guesses.

@th3dstudio
Copy link

Just chiming in here.. There are 2 different CPUs shipping with the Ender 3 S1 boards. One is a STM32F103RCT6 and the other is a STM32F401RCT6. The F4 uses a 40K bootloader and its not playing nice with aftermarket firmware.

@Berglund
Copy link

I've got a STM32F401RCT6 S1 Pro flashed with Klipper. Printing my first calibration cube right now with my printer.cfg based on the one in this PR to see the results.

@filipenobrerc
Copy link

@Sineos
Duly noted.
In case someone is interested on the subject:
https://klipper.discourse.group/t/ender3-s1-pro-motherboard-full-auto-input-shaping-2adxl/2833

@nickgarvey
Copy link

nickgarvey commented May 11, 2022

The limits for bltouch don't seem to be accurate for the S1. I'm surprised as 544a05f seems to address this.

I'm using the most recent file in this PR

$ BED_MESH_CALIBRATE
...
!! Move out of range: 231.800 240.500 5.000 [0.000]

The problem is the 240.5 - y max is 240.

@Fisheiyy
Copy link
Contributor Author

The limits for bltouch don't seem to be accurate for the S1. I'm surprised as 544a05f seems to address this.

I'm using the most recent file in this PR

$ BED_MESH_CALIBRATE
...
!! Move out of range: 231.800 240.500 5.000 [0.000]

The problem is the 240.5 - y max is 240.

I see, its a simple fix just change the y max from 240 to 241

@nickgarvey
Copy link

nickgarvey commented May 11, 2022

I'm going to try these values for the min / max of the motors, then reconfigure the bltouch setting based on that. I'll let you know how it goes.

https://github.com/mriscoc/Ender3V2S1/blob/Ender3V2S1-Released/Marlin/Configuration.h#L1515

@nickgarvey
Copy link

Ended up here with my printer.cfg https://gist.github.com/nickgarvey/b52aa81e0ef14dca58a501880d07df46

I didn't change your extruder settings. When I used a prior version of this PR the print was complete mess, but the most recent extruder settings were much better.

Calibration cube turned out okay. Had some layer shifts & elephant foot but was the best print I've gotten with Klipper so far. Thanks for your time getting this config together.

image

@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented May 11, 2022

Ended up here with my printer.cfg https://gist.github.com/nickgarvey/b52aa81e0ef14dca58a501880d07df46

I didn't change your extruder settings. When I used a prior version of this PR the print was complete mess, but the most recent extruder settings were much better.

Calibration cube turned out okay. Had some layer shifts & elephant foot but was the best print I've gotten with Klipper so far. Thanks for your time getting this config together.

I see no layer shifts only some elephants foot, but it looks fine other than that.

@DK-1989
Copy link

DK-1989 commented May 14, 2022

Ended up here with my printer.cfg https://gist.github.com/nickgarvey/b52aa81e0ef14dca58a501880d07df46

I didn't change your extruder settings. When I used a prior version of this PR the print was complete mess, but the most recent extruder settings were much better.

Calibration cube turned out okay. Had some layer shifts & elephant foot but was the best print I've gotten with Klipper so far. Thanks for your time getting this config together.

image

I have the ender 3 S1 and the S1 PRO and gonna test both printers with this printer.cfg.

I will let you know how my prints turn out.

@Fisheiyy
Copy link
Contributor Author

@KevinOConnor Well, several people have tested now and there has been any new complaints or ones not already fixed, I think this PR is ready to be merged.

@DK-1989
Copy link

DK-1989 commented May 20, 2022

@KevinOConnor Well, several people have tested now and there has been any new complaints or ones not already fixed, I think this PR is ready to be merged.

I have to say that this printer.cfg works great! Only thing i have changed is delete the gear ratio and calculated my own rotation distance ( 7.531 ) with this value i did the pressure advance and now im getting sollid prints without artifacts.

@Fisheiyy
Copy link
Contributor Author

@KevinOConnor Well, several people have tested now and there has been any new complaints or ones not already fixed, I think this PR is ready to be merged.

I have to say that this printer.cfg works great! Only thing i have changed is delete the gear ratio and calculated my own rotation distance ( 7.531 ) with this value i did the pressure advance and now im getting sollid prints without artifacts.

Thats normal with any profile, having to calibrate extruder rotation distance

@Sineos
Copy link
Collaborator

Sineos commented May 22, 2022

If someone around here has the STM32F401 board and a ST-Link, you could make a user over here https://klipper.discourse.group/t/ender3-s1-pro-motherboard-full-auto-input-shaping-2adxl/2833/7?u=sineos very happy

@Fisheiyy
Copy link
Contributor Author

Should I make another PR for the upcoming Ender 3 S1 Plus config or should I just include it here? https://store.creality.com/products/pre-order-code-for-ender-3-s1-plus-3d-printer

@lochej
Copy link

lochej commented May 23, 2022

Thank you for this config file, it works perfectly fine. I'm pretty happy with the results 👍
Installed on an STM32F103 Ender 3 S1 Pro printer today, in Mainsail OS.
Quality is very nice with the stock PLA delivered with the printer.
2 perimeters, 10% infill lines, 80mm/s, 50mm/s walls, minimum layer time 5s
IMG_20220523_163703
IMG_20220523_163631
IMG_20220523_163648

@Sineos
Copy link
Collaborator

Sineos commented May 23, 2022

Should I make another PR for the upcoming Ender 3 S1 Plus

I'd suggest to have this PR merged as soon as possible and handle upcoming hardware in a separate PR

@Fisheiyy
Copy link
Contributor Author

Should I make another PR for the upcoming Ender 3 S1 Plus

I'd suggest to have this PR merged as soon as possible and handle upcoming hardware in a separate PR

Thats what I was thinking since it doesnt actually come out for another 2 weeks? as far as the pre-order code page says because it says June 1st redeem the first 100 codes.

@KevinOConnor KevinOConnor merged commit 00934e1 into Klipper3d:master May 23, 2022
@KevinOConnor
Copy link
Collaborator

Thanks. I committed this with 5a94764 on top.

It would be great if someone could count the number of teeth on the extruder gears of the ender s1 and provide a gear_ratio. (The 3.5:1 is a marketing number and doesn't provide much value.)

-Kevin

@Fisheiyy
Copy link
Contributor Author

Fisheiyy commented May 23, 2022

Thanks. I committed this with 5a94764 on top.

It would be great if someone could count the number of teeth on the extruder gears of the ender s1 and provide a gear_ratio. (The 3.5:1 is a marketing number and doesn't provide much value.)

-Kevin
https://youtu.be/bNXlDwOabqI?t=573

There is another larger black gear in the timestamped video but I cant see it well enough to count its teeth, it would require some to actually disassemble their extruder all the way and it would be almost impossible to put back together probably if its even possible to remove the gear and get a look at it

5x3BjWE96
5x3xwQxl2

edit: Its probably just a generic large gear from a BMG gear kit

5x3FvgbFh

@aartrost
Copy link
Contributor

aartrost commented Jun 2, 2022

Hi all,

Just wanted to mention that the comment in the default Ender 3 S1 config:

# If you prefer a direct serial connection, in "make menuconfig"
# select "Enable extra low-level configuration options" and select
# serial (on USB PA10/PA9), which is broken out on the 10 pin IDC
# cable used for the LCD module as follows:
# 3: Tx, 4: Rx, 9: GND, 10: VCC

Is incorrect (at least for me). I needed to set Serial (on USART2 PA3/PA2) in the the make menuconfig setup to make the serial connection work.

@filipenobrerc
Copy link

For the S1 Pro:
Stepper gear: 12
Extruder drive gear: 42

@anmarcu
Copy link

anmarcu commented Jun 3, 2022

42÷12=3.5 so the ratio is corect. 3.5:1
Thanks

@KevinOConnor
Copy link
Collaborator

Thanks. I added back in the gear_ratio (commit 742df16).

-Kevin

Gi7mo pushed a commit to Gi7mo/klipper that referenced this pull request Feb 15, 2023
Signed-off-by: Rob Casper <myallneedsemail@gmail.com>
tntclaus pushed a commit to tntclaus/klipper that referenced this pull request May 29, 2023
Signed-off-by: Rob Casper <myallneedsemail@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
pending feedback Topic is pending feedback from submitter
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet