New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ender 3 S1/S1 Pro Default Configurations #5332
Conversation
I deleted the repository that #5287 was on because it was a fork of a fork and so I was not getting the commits that official klipper was, so it was not update to date
somebody would complain about no pro config even though its 99% the same printer
@KevinOConnor if you could look over my PR please. |
Thanks. In general it looks fine to me. However, the s1pro config example has a copy-and-paste error in the description on the first 2 lines of the file (it says 2021 s1). Also, it would be preferable to inspect the hardware to find the extruder -Kevin |
Alright, all done and fixed, I completely forgot about the compilation text in the pro config, Also if my PR gets merged shouldn't that mean that #5097 and #5203 since they are basically the same thing? |
I'm not sure where you got the -Kevin |
Oops, I forgot about that, the gear ratio is just listed on the creality page for the Ender 3 S1 and is the same on both the pro and non pro |
I'm not sure where the disconnect is, but the rotation_distance and gear_ratio is definitely incorrect now. As per https://www.klipper3d.org/Example_Configs.html point 7e, the goal is for the rotation_distance to correspond to the circumference of the metal wheel that pushes the filament - it should be a value roughly between 20 and 35. The printer clearly has a gearing mechanism - the best way to figure it out is to look at the gears on the extruder and count the number of teeth on them. -Kevin |
That makes more sense, I dont physically have a reference but just based on some pictures it looks like it has 20 teeth or so, should I therefore change the rotation distance to 20? |
the gear ratio is reversed, it is 1:3.5 and believe it should be 3.5:1 With the gear ratio corrected my ballpark rotation distance is 26 on the stock sprite extruder Also helpful to to add position_min: -3 under [stepper_z] to not run into out of range when calibrating z offset |
@KevinOConnor does this look better? |
Thanks for working on this. However, the extruder config settings are still obviously incorrect. It seems to me that you are "guessing" on the config, and not testing the resulting config. That consumes our time and raises concerns about the overall quality of the submission. Setting the extruder gear_ratio is not a requirement. (Using a gear_ratio where appropriate is preferable as it provides more context to the rotation_distance setting - that value is then the circumference of the wheel pushing the filament - but that convention is not a requirement.) Careful testing of a config is a requirement. -Kevin |
Should I put it back to what it was before at the 7.3 i think it was with no gear ratio? I really cant test the config as I don't have an E3 S1 but my friend is getting one soon and I might be able to get him to test for me but im not sure yet. |
You need to test this on actual hardware, or find others with this printer to test it on theirs before submitting a PR. Something as simple as an incorrect motor direction can lead to a new user crashing their print head. Testing on actual hardware will also make it possible to verify the correct gear_ratio and rotation_distance rather than inaccurate guesses. |
Just chiming in here.. There are 2 different CPUs shipping with the Ender 3 S1 boards. One is a STM32F103RCT6 and the other is a STM32F401RCT6. The F4 uses a 40K bootloader and its not playing nice with aftermarket firmware. |
I've got a STM32F401RCT6 S1 Pro flashed with Klipper. Printing my first calibration cube right now with my printer.cfg based on the one in this PR to see the results. |
@Sineos |
The limits for bltouch don't seem to be accurate for the S1. I'm surprised as 544a05f seems to address this. I'm using the most recent file in this PR
The problem is the 240.5 - y max is 240. |
I see, its a simple fix just change the y max from 240 to 241 |
I'm going to try these values for the min / max of the motors, then reconfigure the bltouch setting based on that. I'll let you know how it goes. https://github.com/mriscoc/Ender3V2S1/blob/Ender3V2S1-Released/Marlin/Configuration.h#L1515 |
Ended up here with my printer.cfg https://gist.github.com/nickgarvey/b52aa81e0ef14dca58a501880d07df46 I didn't change your extruder settings. When I used a prior version of this PR the print was complete mess, but the most recent extruder settings were much better. Calibration cube turned out okay. Had some layer shifts & elephant foot but was the best print I've gotten with Klipper so far. Thanks for your time getting this config together. |
I see no layer shifts only some elephants foot, but it looks fine other than that. |
I have the ender 3 S1 and the S1 PRO and gonna test both printers with this printer.cfg. I will let you know how my prints turn out. |
@KevinOConnor Well, several people have tested now and there has been any new complaints or ones not already fixed, I think this PR is ready to be merged. |
I have to say that this printer.cfg works great! Only thing i have changed is delete the gear ratio and calculated my own rotation distance ( 7.531 ) with this value i did the pressure advance and now im getting sollid prints without artifacts. |
Thats normal with any profile, having to calibrate extruder rotation distance |
If someone around here has the STM32F401 board and a ST-Link, you could make a user over here https://klipper.discourse.group/t/ender3-s1-pro-motherboard-full-auto-input-shaping-2adxl/2833/7?u=sineos very happy |
Should I make another PR for the upcoming Ender 3 S1 Plus config or should I just include it here? https://store.creality.com/products/pre-order-code-for-ender-3-s1-plus-3d-printer |
I'd suggest to have this PR merged as soon as possible and handle upcoming hardware in a separate PR |
Thats what I was thinking since it doesnt actually come out for another 2 weeks? as far as the pre-order code page says because it says June 1st redeem the first 100 codes. |
Thanks. I committed this with 5a94764 on top. It would be great if someone could count the number of teeth on the extruder gears of the ender s1 and provide a gear_ratio. (The 3.5:1 is a marketing number and doesn't provide much value.) -Kevin |
There is another larger black gear in the timestamped video but I cant see it well enough to count its teeth, it would require some to actually disassemble their extruder all the way and it would be almost impossible to put back together probably if its even possible to remove the gear and get a look at it edit: Its probably just a generic large gear from a BMG gear kit |
Hi all, Just wanted to mention that the comment in the default Ender 3 S1 config:
Is incorrect (at least for me). I needed to set |
For the S1 Pro: |
42÷12=3.5 so the ratio is corect. 3.5:1 |
Thanks. I added back in the gear_ratio (commit 742df16). -Kevin |
Signed-off-by: Rob Casper <myallneedsemail@gmail.com>
Signed-off-by: Rob Casper <myallneedsemail@gmail.com>
I forked #5097 because #5203 seemed to be setup in a similar way to a personal config and also the fact that other things were included with that PR, but I have updated the Ender 3 S1 config to better suit how it would come configured on Marlin which the printer ships with.
Signed-off-by: Rob Casper myallneedsemail@gmail.com