Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated to ko 3.0 and updated package.json for npm publishing #358

Merged
merged 3 commits into from Dec 12, 2013
Merged

Updated to ko 3.0 and updated package.json for npm publishing #358

merged 3 commits into from Dec 12, 2013

Conversation

stevegreatrex
Copy link
Contributor

No description provided.

@stevegreatrex stevegreatrex mentioned this pull request Nov 4, 2013
Closed
@stevegreatrex
Copy link
Contributor Author

Resolves #357

@stevegreatrex
Copy link
Contributor Author

We have to remove the package.json dependency on knockout. If left in, npm will download a separate copy of the knockout package as a sub-dependency of this package and if the caller requires knockout separately then the wrong instance of ko will be decorated

@stevegreatrex stevegreatrex merged commit c10dc41 into master Dec 12, 2013
@crissdev crissdev mentioned this pull request Nov 28, 2014
Closed
@crissdev crissdev mentioned this pull request Jan 28, 2015
Closed
@crissdev crissdev deleted the npm-package branch February 6, 2015 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@stevegreatrex