Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#173 Provide CopyPayloadKeyActionFactory from knotx-example #198

Merged
merged 2 commits into from Sep 18, 2020

Conversation

marcinus
Copy link
Contributor

@marcinus marcinus commented Sep 11, 2020

Description

Brings CopyPayloadKeyActionFactory from knotx-example repository.
Registers the factory with name copy-payload-key on SPI.
Provides unit tests and README update.

Motivation and Context

Fixes #173.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@marcinus
Copy link
Contributor Author

Please update CHANGELOG.md before merging

@codecov
Copy link

codecov bot commented Sep 11, 2020

Codecov Report

Merging #198 into master will increase coverage by 0.03%.
The diff coverage is 95.94%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #198      +/-   ##
============================================
+ Coverage     92.03%   92.07%   +0.03%     
- Complexity     1877     1905      +28     
============================================
  Files           179      181       +2     
  Lines          7358     7432      +74     
  Branches        179      180       +1     
============================================
+ Hits           6772     6843      +71     
- Misses          499      502       +3     
  Partials         87       87              
Impacted Files Coverage Δ Complexity Δ
...ts/action/library/CopyPayloadKeyActionFactory.java 94.73% <94.73%> (ø) 9.00 <9.00> (?)
...ction/library/CopyPayloadKeyActionFactoryTest.java 96.36% <96.36%> (ø) 19.00 <19.00> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56ad93b...636e0ef. Read the comment docs.

tomaszmichalak pushed a commit that referenced this pull request Sep 18, 2020
@tomaszmichalak tomaszmichalak merged commit 3449fb6 into master Sep 18, 2020
@tomaszmichalak tomaszmichalak deleted the feature/copy-payload-key-action branch September 18, 2020 21:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move ExposePayloadActionFactory from GraphQL example to core.
2 participants