Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fallback-aware failure handling - make sure snippet with enabled fall… #5

Merged
merged 5 commits into from Dec 12, 2018

Conversation

scypio
Copy link
Contributor

@scypio scypio commented Dec 10, 2018

…back is processed

Implementation of Knotx/knotx#466 in Template Engine

Description

Allows snippets with misconfigured template engine to be processed further by knotx if they have a fallback strategy assigned. Added relevant integration test

Motivation and Context

see Knotx/knotx#466

Screenshots (if appropriate)

Upgrade notes (if appropriate)

N/A

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

I hereby agree to the terms of the Knot.x Contributor License Agreement.

@malaskowski malaskowski merged commit 0ab31a5 into Knotx:master Dec 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants