Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor tweaks & clang++ support & fixes. #12

Merged
merged 5 commits into from
Dec 22, 2014
Merged

Minor tweaks & clang++ support & fixes. #12

merged 5 commits into from
Dec 22, 2014

Conversation

dkorolev
Copy link
Contributor

No description provided.

@@ -1,6 +1,6 @@
.PHONY: test all indent clean check coverage

CPP=g++
CPLUSPLUS?=g++
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What does ?= mean?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Set unless already set in the environment.

This syntax makes make use g++ and CPLUSPLUS=clang++ make use clang++, for this Makefile and all Makefiles invoked from it.

(Edit: It also respects export CPLUSPLUS=clang++ in the environment, of course.)

@biodranik
Copy link
Contributor

Thread local does not work on android

@dkorolev
Copy link
Contributor Author

Bummer, PTAL @deathbaba .

@dkorolev
Copy link
Contributor Author

Two questions, actually:

  1. Is there a c++11-standard way to tell whether thread_local is supported at compile time?
  2. Perhaps I could just use plain std::chrono-s implementation of Now() for Android then, w/o any monotonic magic?

(Side note: MILLISECOND_INTERVAL is signed in Bricks, so time going backwards by a millisecond should not hurt FSQ.)

@biodranik
Copy link
Contributor

1 no
2 yes

On 21.12.2014, at 11.27, Dima notifications@github.com wrote:

Two questions, actually:

Is there a c++11-standard way to tell whether thread_local is supported at compile time?
Perhaps I could just use plain std::chrono-s implementation of Now() for Android then, w/o any monotonic magic?

Reply to this email directly or view it on GitHub.

@dkorolev
Copy link
Contributor Author

Done, PTAL.

Thanks,
Dima

http://dimakorolev.com/ | http://www.linkedin.com/in/dimakorolev |
dmitry.korolev@gmail.com | +1 (312) 593 2783

On Sun, Dec 21, 2014 at 10:30 AM, Alex Zolotarev notifications@github.com
wrote:

1 no
2 yes

On 21.12.2014, at 11.27, Dima notifications@github.com wrote:

Two questions, actually:

Is there a c++11-standard way to tell whether thread_local is supported
at compile time?
Perhaps I could just use plain std::chrono-s implementation of Now() for
Android then, w/o any monotonic magic?

Reply to this email directly or view it on GitHub.


Reply to this email directly or view it on GitHub
#12 (comment).

biodranik added a commit that referenced this pull request Dec 22, 2014
Minor tweaks & clang++ support & fixes.
@biodranik biodranik merged commit fb56bac into KnowSheet:master Dec 22, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants