Skip to content

Commit

Permalink
Rename test
Browse files Browse the repository at this point in the history
  • Loading branch information
justaddcoffee committed Jun 27, 2020
1 parent c2622ca commit 333026a
Show file tree
Hide file tree
Showing 3 changed files with 21 additions and 4 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
import os
from typing import Generator, TextIO, List, Optional

from kg_covid_19.utils.transform_utils import get_item_by_priority, ItemInDictNotFound, guess_category
from kg_covid_19.utils.transform_utils import get_item_by_priority, ItemInDictNotFound, guess_bl_category

from kg_covid_19.transform_utils.transform import Transform
from kg_covid_19.utils import write_node_edge_item
Expand Down Expand Up @@ -66,12 +66,12 @@ def run(self, data_file: str = None):
edge_data = self.gpa_to_edge_data(rec)
subject_node = edge_data[0]
if subject_node not in seen:
subject_node_data = [subject_node, guess_category(subject_node)] + [""] * 4 + [self.source_name]
subject_node_data = [subject_node, guess_bl_category(subject_node)] + [""] * 4 + [self.source_name]
write_node_edge_item(node, self.node_header, subject_node_data)
seen.add(subject_node)
object_node = edge_data[2]
if object_node not in seen:
object_node_data = [object_node, guess_category(object_node)] + [""] * 4 + [self.source_name]
object_node_data = [object_node, guess_bl_category(object_node)] + [""] * 4 + [self.source_name]
write_node_edge_item(node, self.node_header, object_node_data)
seen.add(object_node)

Expand Down
2 changes: 1 addition & 1 deletion kg_covid_19/utils/transform_utils.py
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,7 @@ def unzip_to_tempdir(zip_file_name: str, tempdir: str) -> None:
z.extractall(tempdir)


def guess_category(identifier: str):
def guess_bl_category(identifier: str) -> str:
"""Guess category for a given identifier.
Note: This is a temporary solution and should not be used long term.
Expand Down
17 changes: 17 additions & 0 deletions tests/test_transform_utils.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
import unittest
from parameterized import parameterized
from kg_covid_19.utils.transform_utils import guess_bl_category


class TestTransformUtils(unittest.TestCase):
@parameterized.expand([
['', 'biolink:NamedThing'],
['UniProtKB', 'biolink:Protein'],
['ComplexPortal', 'biolink:Protein'],
['GO', 'biolink:OntologyClass'],
])
def test_guess_bl_category(self, curie, category):
self.assertEqual(category, guess_bl_category(curie))



0 comments on commit 333026a

Please sign in to comment.