Improvements to Jenkinsfile #147
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kltm
reviewed
May 11, 2020
Jenkinsfile
Outdated
| sh 'cd config;. venv/bin/activate; pigz merged-kg.tar' | ||
| dir('./gitrepo') { | ||
| sh '. venv/bin/activate; python3.7 run.py load' | ||
| sh '. venv/bin/activate; pigz merged-kg.tar' |
There was a problem hiding this comment.
run.py load needs the venv environment - I guess pigz doesn't though
Jenkinsfile
Outdated
| sh 'cd config;. venv/bin/activate; pigz merged-kg.nt' | ||
| dir('./gitrepo') { | ||
| sh '. venv/bin/activate; kgx transform --input-type tsv --output-type nt -o ./merged-kg.nt merged-kg.tar.gz' | ||
| sh '. venv/bin/activate; pigz merged-kg.nt' |
There was a problem hiding this comment.
all the run.py commands will need this, possibly kgx too. Looks like I can remove it from the pigz command though
Jenkinsfile
Outdated
| if (run_py_dl == 0) { // upload raw to s3 | ||
| sh 's3cmd -c $S3CMD_JSON --acl-public --mime-type=plain/text --cf-invalidate put -r data/raw s3://kg-hub-public-data/' | ||
| } else { // 'run.py download' failed - let's try to download last good copy of raw/ from s3 to data/ | ||
| sh 'rm -fr data/raw; mkdir -p data/raw' |
There was a problem hiding this comment.
I might suggest:
'rm -r -f data/raw || true'
'mkdir -p data/raw || true'
or functionally similar
Jenkinsfile
Outdated
| sh 'cd config;. venv/bin/activate; python3.7 run.py load' | ||
| sh 'cd config;. venv/bin/activate; pigz merged-kg.tar' | ||
| dir('./gitrepo') { | ||
| sh '. venv/bin/activate; python3.7 run.py load' |
There was a problem hiding this comment.
probably a good idea
justaddcoffee
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cd gitrepo