Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates for newest grape #82

Merged
merged 23 commits into from
Jun 16, 2022
Merged

Updates for newest grape #82

merged 23 commits into from
Jun 16, 2022

Conversation

caufieldjh
Copy link
Contributor

@caufieldjh caufieldjh commented Jun 8, 2022

See linked issue (#81).

@caufieldjh caufieldjh linked an issue Jun 8, 2022 that may be closed by this pull request
3 tasks
@caufieldjh
Copy link
Contributor Author

caufieldjh commented Jun 8, 2022

Getting an ImportError:

 ImportError: cannot import name 'LinkPredictionTransformer' from 'grape' (/opt/hostedtoolcache/Python/3.8.12/x64/lib/python3.8/site-packages/grape/__init__.py)

Where are the transformers now?
(They're in grape.transformers, and LinkPredictionTransformer is EdgePredictionTransformer

@caufieldjh
Copy link
Contributor Author

Not entirely sure what to do with generating BERT embeddings for now - neat_schema doesn't include params for it, and not sure what is or isn't in Embiggen to support it

@caufieldjh
Copy link
Contributor Author

A work in progress note:

  File "/home/harry/neat-env/lib/python3.8/site-packages/neat/cli.py", line 84, in run
    train_data, validation_data = model.make_train_valid_data(
  File "/home/harry/neat-env/lib/python3.8/site-packages/neat/link_prediction/model.py", line 93, in make_train_valid_data
    graph_args["directed"] = training_graph_args["directed"]
TypeError: 'str' object does not support item assignment

Looks like something that should be a dict isn't one - not sure what's happening yet

@caufieldjh
Copy link
Contributor Author

This now appears to work as expected, with the sole caveat that the edge prediction methods have not been replaced with the grape methods - they are still our own sklearn/tf methods.

I'd like to split that part of the update into its own PR so we can complete the name change and get NEAT on Pypi.

@caufieldjh caufieldjh marked this pull request as ready for review June 16, 2022 16:06
@caufieldjh caufieldjh merged commit 0d0b389 into main Jun 16, 2022
@caufieldjh caufieldjh deleted the update_for_grape branch September 27, 2022 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update for Ensmallen / Embiggen -> grape
2 participants