-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Making neat-ml poetry-fied (plus tox, black, flake8, and mypy updates) #88
Conversation
This is pretty strange - I'm having difficulty establishing the path for
|
Aah ... I think I know what the problem is. I need to fix it in |
Alright, releasing a new version of |
Alright, this passes! I have implemented |
Let's take care of the reformatting here too |
I will need help with |
Not sure what's going on with ensmallen or why poetry can't find it to install. |
There may be some strange python version interaction between poetry, ensmallen, and OS - the Going to try deactivating the windows tests as I don't think |
OK, now it makes it to pytest but just takes far too long. Probably trying to make a real embedding by accident. |
Tests are still taking too long - I suspect this test is the culprit: neat-ml/tests/test_link_prediction.py Line 95 in 424c365
|
Hrm, looks like it may just need the extra imports to be test dependencies. Will try that. |
See AnacletoLAB/grape#12 - just ran into this |
Looks like this is working - tests are still running long, but I think that's because it includes all the tensorflow and sklearn stuff that generally runs quickly (i.e., not 100 minutes) if it isn't on a GH actions instance. |
Hrm, the tests install TF and scikit-learn, but it's strange that they still take so long. |
poetry
the main package management systemtox
withinpoetry
and within it: