This repository has been archived by the owner on Sep 23, 2022. It is now read-only.
Scoring refactoring #134
Closed
Scoring refactoring #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -0,0 +1,35 @@ | |||
| <?php | |||
|
|
|||
| namespace Knp\Bundle\KnpBundlesBundle\EventDispatcher; | |||
There was a problem hiding this comment.
it should be Event to be consistent with Symfony
|
@Palleas you should update your PR so that github sees that the first commits are merged now (it won't change the diff if the PR is untouched) |
added 21 commits
February 11, 2012 18:34
…e consistent with Symfony
|
@stof I think I've fixed everything now, thanks for your review :) |
|
|
||
| /** | ||
| * | ||
| */ |
There was a problem hiding this comment.
and same for all other created by copy-paste
|
|
||
| class BundleEvent extends Event | ||
| { | ||
|
|
|
merged |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This should be easier to merge when this PR is merged)
This is a new "approach" for the scoring algorithm, using the event dispatcher to make it more easy to maintain and less coupled to the whole update process.
Let me know what you think! :)