listen to other exceptions #748
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexpozzi
reviewed
Dec 9, 2022
Comment on lines
26
to
44
| private static function isInternalException(UnexpectedValueException $exception): bool | ||
| { | ||
| $messages = [ | ||
| '/^Cannot filter by\: \[.+\] this field is not in allow list$/', | ||
| '/^Cannot sort by\: \[.+\] this field is not in allow list\.$/', | ||
| '/^Cannot sort with array parameter$/', | ||
| '/^ODM query must be a FIND type query$/', | ||
| '/^There is no component aliased by \[.+\] in the given Query$/', | ||
| '/^There is no component field \[.+\] in the given Query$/', | ||
| '/^There is no such field \[.+\] in the given Query component, aliased by \[.+\]$/', | ||
| ]; | ||
| foreach ($messages as $regex) { | ||
| if (preg_match($regex, $exception->getMessage()) > 0) { | ||
| return true; | ||
| } | ||
| } | ||
|
|
||
| return false; | ||
| } |
There was a problem hiding this comment.
I'm usually not so fond of matching an exception by its message, especially if we control those exceptions.
Can't we create instead a custom exception (that's extending the UnexpectedValueException) and catch that instead of matching the messages?
There was a problem hiding this comment.
I agree and I already opened an issue for that KnpLabs/knp-components#317
The problem is that we can only add the internal exception in a minor release of knp-components (e.g. 4.1.0) and so the fix in this bundle would stay for the users still using version 4.0.
My idea about the roadmap is:
- add the internal exception in the library, release a minor version of the library
- add support in the bundle for both (new internal exception and ugly old message-based exceptions), release a patch version of the bundle
- release a new minor version of the bundle, requiring library ^4.1 and removing the ugly old message-based exceptions
There was a problem hiding this comment.
Great! Sorry, I missed that issue.
Thank you!
alexpozzi
approved these changes
Dec 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #747