-
Notifications
You must be signed in to change notification settings - Fork 143
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
- Loading branch information
Albin Kerouanton
committed
Sep 20, 2017
1 parent
1d3a89d
commit 2a959b5
Showing
7 changed files
with
54 additions
and
47 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,28 +1,18 @@ | ||
<?xml version="1.0" ?> | ||
|
||
<container xmlns="http://symfony.com/schema/dic/services" | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
|
||
<parameters> | ||
<parameter key="knp_snappy.image.internal_generator.class">Knp\Snappy\Image</parameter> | ||
<parameter key="knp_snappy.image.class">Knp\Bundle\SnappyBundle\Snappy\Generator\LoggableGenerator</parameter> | ||
</parameters> | ||
xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
xsi:schemaLocation="http://symfony.com/schema/dic/services http://symfony.com/schema/dic/services/services-1.0.xsd"> | ||
|
||
<services> | ||
|
||
<service id="knp_snappy.image.internal_generator" class="%knp_snappy.image.internal_generator.class%" public="false"> | ||
<service id="knp_snappy.image" class="Knp\Snappy\Image" public="false"> | ||
<argument>%knp_snappy.image.binary%</argument> | ||
<argument>%knp_snappy.image.options%</argument> | ||
<argument>%knp_snappy.image.env%</argument> | ||
</service> | ||
|
||
<service id="knp_snappy.image" class="%knp_snappy.image.class%"> | ||
<argument type="service" id="knp_snappy.image.internal_generator" /> | ||
<argument type="service" id="logger" on-invalid="null" /> | ||
<call method="setLogger"> | ||
<argument type="service" id="logger" on-invalid="ignore" /> | ||
</call> | ||
<tag name="monolog.logger" channel="snappy" /> | ||
</service> | ||
|
||
</services> | ||
|
||
</container> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2a959b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have a question.
You switch knp-snappy from ~0.1 to ~1.0, which is major I think.
And wrapper library have only minor version change.
Is normal practice? Is there some reason for that?
reagards,
2a959b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @LiSinCin. It actually depends if your own API (in this case, the API of the bundle) changes. If not, no need of a major release. Semver is pretty clear about this case: http://semver.org/#what-should-i-do-if-i-update-my-own-dependencies-without-changing-the-public-api
2a959b5
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was no major changes in the library, but we thought it was time to release the first stable version ever because pretty much nothing has changed in the past two years. As said by @Einenlum, no BC change on the bundle was needed so a minor version is fine. But I disallowed
knp-snappy
< 1.0 to be used with the v1.5 of the bundle because I moved the logging capability to the generators and have deprecatedLoggableGenerator
.