Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: security advisory GHSA-92rv-4j2h-8mjj #488

Merged
merged 1 commit into from
Sep 6, 2023
Merged

fix: security advisory GHSA-92rv-4j2h-8mjj #488

merged 1 commit into from
Sep 6, 2023

Conversation

alexpozzi
Copy link
Member

No description provided.

@alexpozzi alexpozzi merged commit d3b742d into master Sep 6, 2023
21 checks passed
@alexpozzi alexpozzi deleted the fix/security-advisory-GHSA-92rv-4j2h-8mjj branch September 6, 2023 15:24
@xicond
Copy link

xicond commented Sep 11, 2023

it's causing windows support removed,
parse_url doesn't has same behavior in windows
in windows scheme will result drive letter
which will throw new InvalidArgumentException

@alexpozzi
Copy link
Member Author

There is already an opened issue for that #489

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PedroTroller PedroTroller PedroTroller approved these changes

@AntoineLelaisant AntoineLelaisant AntoineLelaisant approved these changes

Assignees

@qroques qroques

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@alexpozzi @xicond @PedroTroller @AntoineLelaisant @qroques